-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Not building with RN 0.70, Reanimated 3 🐛 #1210
Comments
Also getting the same issue with:
Looks like |
Getting the same issue with:
|
i'm having issues with |
I'm having issue with "react-native": "0.70.0",
"react-native-reanimated": "^3.0.0-rc.2",
"react-native-vision-camera": "^2.14.1", too. |
When I upgrade RN to 0.70 from 0.69.3 the build is going to gave an error. I think the library doesn't support RN 0.70 pls fix soon |
We are having the same issues, we currently have this versions:
Hope this get fixed soon! |
Same case here, having issues with |
Recently moved to 0.70. |
+1 Having the same. react-native": "0.70.0 |
issue with cmake :( react-native: "0.70.0" |
I'm having issue with "react-native": "0.70.0",
"react-native-reanimated": "^3.0.0-rc.2",
"react-native-vision-camera": "^2.14.1", |
+1 |
Also having issues with
|
Hey girls and guys, I think we can stop posting our versions, the maintainers probably get the gist. |
Any update on this? |
Hey guys, for those who are struggling with using this with RN 0.70.0, I managed to make it work (dev and prod) with the following package.json (as a fix is in main but not published as version) :
Of course, don't forget to clean your gradle build, launch with android and start a clean metro: cd android && ./gradlew clean && cd ..
npx react-native run-android
npx react-native start -- --reset-cache |
I don't think this is the problem described in the issue. @erksch did not summarize precisely, because 2.10.0 is actually compatible with rn 0.70.0. You can easily use rn 0.70.0 together with current (not pre-releases) published versions of both libraries. In some cases you might have the the following issue #1118 which was fixed in the main branch of this repo. Problem is when you want to try out the newArch (see here how to try it yourself) because then you need to use reanimated 3 which does not include the |
I ran into this issue as well. Any news on this? |
@DomiR could rolling back some of these commits https://github.com/mrousavy/react-native-vision-camera/pull/1186/commits provide a solution for us? |
it actually looks good to me, i only upgraded react-native-reanimated to the release candidate because of this: |
@vbylen Hey, no! That commit consumes hermes from source (instead of prebuilt). Now reanimated also does not distribute prebuilt anymore so we basically need to do the same - consume reanimated from source (instead of prebuilt). As I'm no gradle ninja and only try to make it work I don't know the most elegant solution. I wanted to test fabric but I'm blocked by other libs but I can show you how to make vision camera consume the new reanimated temporarily (hermes + newarch). Let me explain: These are then extracted by vision camera here: react-native-vision-camera/android/build.gradle Lines 583 to 595 in cc7d195
Which is beeing configured here: react-native-vision-camera/android/build.gradle Lines 282 to 283 in cc7d195
Afterwards the vision camera node_modules folder looks like this and you can see that in the build folder of android there is the extracted aar containing the .so files: We therefore first need to disable this extraction. Just patch the line L283 and remove reanimated: The solution to this issue would be to either create a gradle task to copy over the generated .so files or somehow link them directly. As I said I don't know the most elegant solution. In the meantime we can do this by hand. Second step is to update the CMakeList.txt in vision camera as the reanimated flattened the headers directory here: So instead of react-native-vision-camera/android/CMakeLists.txt Lines 63 to 70 in cc7d195
We need this:
As I mentioned I could not verify as I'm running into issues with other libs. Harder part is now to support multiple versions of reanimated where you need to pick the correct tasks depending on the version of reanimated you have installed, sorry to be no help here 😢 |
@NastuzziSamy how to install this package? could you provide more information?thanks |
Hi @kamo9527 , you just have to copy/paste the deps in your package.json (check that you have no duplications) I would recommand to delete your And then run the following scripts described in my comment. |
|
@kamo9527 - just add that line exactly as is show to
However @NastuzziSamy , couldn't get it to work with those exact versions, still getting |
@DomiR Did you manage to make your app work with Fabric, react-native-vision-camera and react-native-reanimated? |
"react-native-vision-camera": "^2.15.2", Please check announcement from ReactNative page: https://reactnative.dev/blog/2022/09/05/version-070 build.gradle is still using "Android.mk", but latest ReactNative does not have Android.mk file, but CMakeLists.txt |
same here. Execution failed for task ':react-native-vision-camera:extractJNIFiles'.
@mrousavy need help. |
do you sloved. |
|
Got a different error with these versions when building on ios:
and then I found this software-mansion/react-native-reanimated#3831 (comment).
|
confirmed, does not works with reanimated 3.x, and reanimated 2.x does not build with newArch enabled, so, no Fabric for Vision camera for now, maybe on #1376 |
indeed. v3 will work on Fabric. |
Any updates on V3 reanimated support? |
Been scratching my head with this for a couple of days now, seem on a new RN project. Trying to migrate the older code and it uses vision camera however it won't play nice with V3 reanimated either. On an M2 Mac if that makes any difference. Tried various versions of Reanimated 2 and it won't compile so try V3 and also won't compile. |
Again, VisionCamera V2 works with Reanimated V2. It does not work with Reanimated V3. VisionCamera V3 ✨ will not use Reanimated anymore, so it will automatically work with Reanimated V3 (and V2 and V1 or no Reanimated installed at all). VisionCamera V3 will soon be ready, but I only work on it in my free time. If you want to accelerate this, consider sponsoring me on GitHub ❤️ or buying me a coffee on Kofi ☕ |
I am using reanimated 2.4.1 I changed this to then run this command: this solved the issue |
I fixed this this solution |
What version of react native do you use, to test this solution |
"react": "18.2.0", |
Yes, it does compile but if you want to use Frame Processors, it throws an error. I tried to solve it with this thread (#1533) but it did not achieve any effect. " ERROR frame-processor/unavailable: Frame Processors are not enabled. See https://react-native-vision-camera.com/docs/guides/troubleshooting, js engine: hermes" |
V3 fixes this |
@mrousavy any update on when V3 arrives ? |
Closing as this is a stale issue - this might have been fixed with the full rewrite in VisionCamera V3 (🥳) - if not, please create a new issue. |
What were you trying to do?
Trying to build the app using release candidates of RN 0.70 and Reanimated 3
Reproduceable Code
No response
What happened instead?
Build failed because there are no aar now: both RN and Reanimated are building from source from 0.70
Relevant log output
Device
Pixel 3
VisionCamera Version
2.14.1
Additional information
The text was updated successfully, but these errors were encountered: