Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug: null values inside prepareGetFeatureUrl #19

Open
jokiefer opened this issue Mar 18, 2024 · 0 comments
Open

Bug: null values inside prepareGetFeatureUrl #19

jokiefer opened this issue Mar 18, 2024 · 0 comments
Labels
bug Something isn't working

Comments

@jokiefer
Copy link
Member

status quo

the prepareGetFeatureUrl function is not null safe

mrmap-react-admin/src/components/MapViewer/MapViewerContext.tsx

Line 147 in 049e625

params.append('SRS', getMapUrl.searchParams.get('SRS'))

This will run in to errors for wms 1.3.0 for example, cause the .get('SRS') will always return null in that case, cause the query param is CRS in version 1.3.0

ToDo

make it null safe for all versions
@jokiefer jokiefer added the bug Something isn't working label Mar 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jokiefer