Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Does not follow redirects correctly when redirects goes via javascript #4

Open
dcantatore opened this issue Sep 1, 2020 · 2 comments
Labels
enhancement New feature or request

Comments

@dcantatore
Copy link
Contributor

Use this url as a test example:
https://strava.app.link/JWlb3MpOl9

Here is the return from your package:

[
  {
    url: 'https://strava.app.link/JWlb3MpOl9',
    code: 200,
    cookies: {
      _s: 'XXXXXXXXX',
      'Max-Age': '31536000',
      Domain: '.app.link',
      Path: '/',
      Expires: 'Wed, 01 Sep 2021 20:16:44 GMT'
    },
    queryParams: [Object: null prototype] {}
  }
]

But in the browser it does a 307 followed by a 302

@mrdaano
Copy link
Owner

mrdaano commented Sep 1, 2020

Thanks for reporting this issue.
I see what you mean and I will look into it.

@mrdaano mrdaano added the bug Something isn't working label Sep 1, 2020
@mrdaano
Copy link
Owner

mrdaano commented Sep 8, 2020

I've looked into it. The url you provided does a javascript redirect instead of via the headers.

At the moment this library doesn't support javascript redirects. But it is a feature that I want to add so I will see if I can find a solution that can cover all javascript redirects.

@mrdaano mrdaano added enhancement New feature or request and removed bug Something isn't working labels Sep 8, 2020
@mrdaano mrdaano changed the title Does not follow redirects correctly Does not follow redirects correctly when redirects goes via javascript Sep 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants