mrc-5445 Make e2e tests run in parallel #42
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #42 +/- ##
=======================================
Coverage 89.69% 89.69%
=======================================
Files 33 33
Lines 2155 2155
Branches 224 224
=======================================
Hits 1933 1933
Misses 216 216
Partials 6 6 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Thank you for doing this!
Reference:
https://playwright.dev/docs/test-sharding
There was a problem hiding this comment.
Great stuff! Just wondering if it would be possible to tersify it a little?
Could this be tidied up a little by having 6 jobs in a single workflow rather than 6 separate workflows? Jobs are executed on separate runners and in parallel by default, aren't they, so wouldn't that get the parallelism we want? That would mean we'd just need one yml file and wouldn't have the repetition of on..?
package.json
Outdated
| @@ -14,7 +14,13 @@ | |||
| "lint": "eslint . --ignore-path .gitignore", | |||
| "test:unit": "vitest", | |||
| "test:coverage": "vitest --coverage", | |||
| "test:e2e": "playwright test" | |||
| "test:e2e": "playwright test", | |||
| "test:e2e:1": "playwright test --shard=1/6", | |||
There was a problem hiding this comment.
Do you actually need these? You can pass command line args through to the npm scripts, so couldn't you just call
npm run test:e2e -- --shard=${{ inputs.shard }}/6 from the action?
There was a problem hiding this comment.
thanks, that is much better! also done it in one workflow file!
e2e tests felt slow and considering that we are relying more on them in this project, it would be nice to get on top of this now