Apply suggestions from code review

mratsim · Sep 17, 2023 · 6724ed8 · 6724ed8
1 parent cc5c175
commit 6724ed8
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/constantine/commitments/kzg_polynomial_commitments.nim b/constantine/commitments/kzg_polynomial_commitments.nim
@@ -378,7 +378,7 @@ func kzg_verify_batch*[bits: static int, F2; C: static Curve](
   # We interleave allocation and deallocation, which hurts cache reuse
   # i.e. when alloc is being done, it's better to do all allocs as the metadata will already be in cache
   #
-  # but it's more important to minimize memory usage especially if we want to comit with 2^26+ points
+  # but it's more important to minimize memory usage especially if we want to commit with 2^26+ points
   #
   # We dealloc in reverse alloc order, to avoid leaving holes in the allocator pages.
   let commits_min_evals = allocHeapArrayAligned(ECP_ShortW_Aff[Fp[C], G1], n, alignment = 64)

diff --git a/constantine/ethereum_eip4844_kzg_polynomial_commitments.nim b/constantine/ethereum_eip4844_kzg_polynomial_commitments.nim
@@ -290,7 +290,7 @@ func blob_to_kzg_commitment*(
     check HappyPath, poly.blob_to_bigint_polynomial(blob)
 
     var r {.noinit.}: ECP_ShortW_Aff[Fp[BLS12_381], G1]
-    kzg_commit(r, poly.evals, ctx.srs_lagrange_g1) # symbol resolution need explicit generics
+    kzg_commit(r, poly.evals, ctx.srs_lagrange_g1)
     discard dst.serialize_g1_compressed(r)
 
     result = cttEthKZG_Success