From 2c3de8738d031394dfb78e3fc839cf5d12e42b92 Mon Sep 17 00:00:00 2001 From: Mamy Ratsimbazafy Date: Mon, 7 Oct 2024 10:20:12 +0200 Subject: [PATCH] Fixes for Nim v2.2 (#476) * CI: echo scheduled commands * ci: revert echo scheduled command + don't create pipe for any != 1.6 branch * no LTO for windows 2.2, impossible constraint in deneb_kzg test * ci: typo on CTT_LTO --- .github/workflows/ci.yml | 9 +++++---- helpers/pararun.nim | 2 +- 2 files changed, 6 insertions(+), 5 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 056ac709..d904e690 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -372,12 +372,13 @@ jobs: # So "test_bindings" uses C and can find GMP # but nim-gmp cannot find GMP on Windows CI # Also need to workaround asynctools not being able to create pipes https://github.com/nim-lang/Nim/issues/23118 + # And LTO impossible constraint in the deneb_kzg test (but not MSM for some reason) if: runner.os == 'Windows' && matrix.target.BACKEND == 'ASM' shell: msys2 {0} run: | cd constantine - if [[ '${{ matrix.nim_version }}' == 'version-2-0' ]]; then - nimble test_no_gmp --verbose + if [[ '${{ matrix.nim_version }}' != 'version-1-6' ]]; then + CTT_LTO=0 nimble test_no_gmp --verbose else nimble test_parallel_no_gmp --verbose fi @@ -389,8 +390,8 @@ jobs: shell: msys2 {0} run: | cd constantine - if [[ '${{ matrix.nim_version }}' == 'version-2-0' ]]; then - CTT_ASM=0 nimble test_no_gmp --verbose + if [[ '${{ matrix.nim_version }}' != 'version-1-6' ]]; then + CTT_ASM=0 CTT_LTO=0 nimble test_no_gmp --verbose else CTT_ASM=0 nimble test_parallel_no_gmp --verbose fi diff --git a/helpers/pararun.nim b/helpers/pararun.nim index ec44dcb0..d884e3f7 100644 --- a/helpers/pararun.nim +++ b/helpers/pararun.nim @@ -191,4 +191,4 @@ proc main() = runCommands(commandFile, numWorkers) when isMainModule: - main() \ No newline at end of file + main()