Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Import shader from shadertoy problems #11

Open
seb776 opened this issue Aug 5, 2023 · 0 comments
Open

Import shader from shadertoy problems #11

seb776 opened this issue Aug 5, 2023 · 0 comments

Comments

@seb776
Copy link

seb776 commented Aug 5, 2023

Hello there,

I tried using the ISFEditor to convert some of my shaders to ISF format but apparently there are a few issues
Here's the shader I tried
https://www.shadertoy.com/view/7s2Sz3

The errors I spotted :

  • It does not import the common tab (it's probably easy to fix as it simply requires code concatenation)
  • When doing multipass shaders, it does not handle multiple functions having the same name (would require a kind of mangling / namespace to the names)
    Here's a detailed list of the errors I got from the editor

Fragment shader errros:

0(41) : error C1038: declaration of "iChannel2" conflicts with previous declaration at 0(15)
0(42) : error C1038: declaration of "_iChannel2_imgRect" conflicts with previous declaration at 0(16)
0(43) : error C1038: declaration of "_iChannel2_imgSize" conflicts with previous declaration at 0(17)
0(44) : error C1038: declaration of "_iChannel2_flip" conflicts with previous declaration at 0(18)
0(91) : error C1503: undefined variable "r2d"
0(93) : error C1503: undefined variable "sat"
0(100) : error C1503: undefined variable "r2d"
0(106) : error C1503: undefined variable "r2d"
0(107) : error C1503: undefined variable "sat"
0(173) : error C1503: undefined variable "sat"
0(215) : error C1503: undefined variable "sat"
0(215) : error C1503: undefined variable "sat"
0(234) : error C1503: undefined variable "sat"
0(235) : error C1503: undefined variable "sat"
0(244) : error C1503: undefined variable "sat"
0(249) : error C1503: undefined variable "sat"
0(249) : error C1503: undefined variable "sat"
0(264) : error C1503: undefined variable "sat"
0(265) : error C1503: undefined variable "sat"
0(300) : error C1503: undefined variable "sat"
0(300) : error C1503: undefined variable "sat"
0(303) : error C1503: undefined variable "r2d"
0(306) : error C1503: undefined variable "r2d"
0(325) : error C1503: undefined variable "iChannel0"
0(364) : error C1013: function "rdr" is already defined at 0(262)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant