Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Potential bug with MBTN_RIGHT / MBTN_RIGHT_DBL handling #634

Open
Sneakpeakcss opened this issue Jan 4, 2024 · 2 comments
Open

Potential bug with MBTN_RIGHT / MBTN_RIGHT_DBL handling #634

Sneakpeakcss opened this issue Jan 4, 2024 · 2 comments
Assignees

Comments

@Sneakpeakcss
Copy link
Collaborator

Describe the bug

While testing mouse controls i've noticed that mpv.net seems to be having issues with detecting consecutive MBTN_RIGHT clicks, even when it's unbinded from default context menu command, or when defined as MBTN_RIGHT ignore.

On top of that… MBTN_RIGHT_DBL seems to only be detected on third mouse click.
And if this is any clue… When MBTN_RIGHT_DBL is unbinded, mpv.net doesn't seem to send the typical message:

[input] No key binding found for key 'MBTN_RIGHT_DBL'

like it happens in mpv.

 

Steps to reproduce the behavior:

  1. Either use RMB in the linked seek-to.lua script or put this into input.conf:
MBTN_Right script-message-to console type "print-text 'MBTN_Right'" ; keypress ENTER
MBTN_Right_dbl script-message-to console type "print-text 'MBTN_Right_dbl'" ; keypress ENTER

Screenshots
In case of the mentioned .lua script:

Spamming RMB in mpv.net

1mpvnetspam.mp4

And in mpv for comparison

2mpvspam.mp4

3RMBspamcomparison.mp4
4mpvnettrippleclick.mp4

Expected behavior

MBTN_RIGHT should detect every single click the same as in mpv, and MBTN_RIGHT_DBL shouldn't require 3 clicks.

At first i thought that this might not be a bug, since mpv.net uses the RMB for handling the context menu. On the other hand, it does this through a normal command like any other hotkey, so the disparity seems a bit odd, especially when MBTN_RIGHT is unbinded or when forced by mp.add_forced_key_binding.

Additional context

  1. mpv.net version: mpv.net 7.0.0.5 (28.12.2023)
  2. Windows version WIN10 22H2
  3. GPU name RX570
@Sneakpeakcss Sneakpeakcss changed the title Potential bug with `MBTN_RIGHT / MBTN_RIGHT_DBL handling Potential bug with MBTN_RIGHT / MBTN_RIGHT_DBL handling Jan 4, 2024
@stax76
Copy link
Collaborator

stax76 commented Jan 5, 2024

I hope I can reproduce and fix it.

@stax76
Copy link
Collaborator

stax76 commented Jan 7, 2024

I couldn't get something that works better, unfortunately.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants