Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance/Improve node selection algorithm for ValidateAndExportModel #531

Closed
3 tasks done
mpostol opened this issue Feb 15, 2021 · 2 comments · Fixed by #572
Closed
3 tasks done

Enhance/Improve node selection algorithm for ValidateAndExportModel #531

mpostol opened this issue Feb 15, 2021 · 2 comments · Fixed by #572

Comments

@mpostol
Copy link
Owner

mpostol commented Feb 15, 2021

Describe problem

Now the method ValidateAndExportModel uses conditions defined in Part 5 8 Standard Objects and their Variables - it exports the selected model from an internal Address Space. It means that the node is neglected if it is not on the browse path available for an abstract client.

Describe the solution you'd like

At least all nodes imported from an external file and not selected for validation must be subject to error generation procedure.

Describe alternatives you've considered

  • mark nodes as orphaned
  • process all nodes aggregated by a selected model and generate an error for all orphaned nodes - a violation of rules defined in Part 5-8

List of tasks to be accomplished

  • define model term
  • reconsider conditions used for selection of Nodes and define the algorithm
  • clarify what the the model contains 8 nodes actually means

Notes

Add any other context or screenshots about the feature request here.

A blocker for #510

@mpostol mpostol added the Feature request Consider to apply label Feb 15, 2021
@mpostol mpostol self-assigned this Feb 15, 2021
@mpostol mpostol added this to the SemanticData_6.1.3 milestone Feb 15, 2021
mpostol added a commit that referenced this issue Feb 16, 2021


- added a document with selected snippets from the spec
mpostol added a commit that referenced this issue Feb 18, 2021


- working on the document docs/ObjectModelSpecyficatio.md
- added new section `Address Space Concept Executive Summary`
- work in progress
@mpostol
Copy link
Owner Author

mpostol commented Feb 18, 2021

@jouniaro - referring to the discussion related to Naming Conventions for Nodes let me give you an update:

  • I will address this topic using this issue (all commits will be interconnected to this issue).
  • The document name is pointed out in the last commit.
  • The work is conducted on the branch SemanticData-6.1.3
  • As an introduction, I have just added a new section Address Space Concept Executive Summary - it is ready for review
  • I will continue but need one or two days to finish

@mpostol mpostol added Documentation Documentation modification request Help wanted Looking for contributors and removed Feature request Consider to apply labels Feb 18, 2021
mpostol added a commit that referenced this issue Feb 18, 2021


- working on the document docs/ObjectModelSpecyficatio.md
mpostol added a commit that referenced this issue Mar 16, 2021
mpostol added a commit that referenced this issue Mar 16, 2021
Enhance/Improve node selection algorithm for ValidateAndExportModel #531
@mpostol
Copy link
Owner Author

mpostol commented Apr 5, 2021

Further documentation development has been forked to #563

mpostol added a commit that referenced this issue Apr 5, 2021
- document template
- BrowseName
- Forked from #531
@mpostol mpostol added question Refactoring and removed Documentation Documentation modification request Help wanted Looking for contributors labels Apr 5, 2021
mpostol added a commit that referenced this issue Apr 6, 2021


- added anchors to start investigation of the code.
mpostol added a commit that referenced this issue Apr 10, 2021


- fixes #531
- refactored ValidateAndExportModel - unimportant changes
mpostol added a commit that referenced this issue Apr 10, 2021
Enhance/Improve node selection algorithm for ValidateAndExportModel #531
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant