From b64d3efb802242b0f6e99e0b2dcb17021e4b14f2 Mon Sep 17 00:00:00 2001 From: MPostol Date: Wed, 9 Mar 2022 12:19:02 +0100 Subject: [PATCH] NetworkIdentifier is missing in generated Model Design for DI model #629 - fixed anchor id - unimportant changes --- .../UANodeSetValidation/AddressSpaceContext.cs | 4 ++-- SemanticData/UANodeSetValidation/UANodeContext.cs | 7 ++++--- .../UANodeSetValidation/UAReferenceContext.cs | 13 ++++++------- 3 files changed, 12 insertions(+), 12 deletions(-) diff --git a/SemanticData/UANodeSetValidation/AddressSpaceContext.cs b/SemanticData/UANodeSetValidation/AddressSpaceContext.cs index 7f339d44..d2d4d96b 100644 --- a/SemanticData/UANodeSetValidation/AddressSpaceContext.cs +++ b/SemanticData/UANodeSetValidation/AddressSpaceContext.cs @@ -1,6 +1,6 @@ //__________________________________________________________________________________________________ // -// Copyright (C) 2021, Mariusz Postol LODZ POLAND. +// Copyright (C) 2022, Mariusz Postol LODZ POLAND. // // To be in touch join the community at GitHub: https://github.com/mpostol/OPC-UA-OOI/discussions //__________________________________________________________________________________________________ @@ -217,7 +217,7 @@ IEnumerable IAddressSpaceBuildContext.GetReferences2Me(IUANo /// /// The root node of the requested children. /// Return an instance of capturing all children of the selected node. - //TODO NetworkIdentifier is missing in generated Model Design for DI model #51 + //TODO NetworkIdentifier is missing in generated Model Design for DI model #629 public IEnumerable GetChildren(IUANodeBase node) { return m_References.Values.Where(x => Object.ReferenceEquals(x.SourceNode, node)). diff --git a/SemanticData/UANodeSetValidation/UANodeContext.cs b/SemanticData/UANodeSetValidation/UANodeContext.cs index 244a3fa8..6a126f7c 100644 --- a/SemanticData/UANodeSetValidation/UANodeContext.cs +++ b/SemanticData/UANodeSetValidation/UANodeContext.cs @@ -1,6 +1,6 @@ //__________________________________________________________________________________________________ // -// Copyright (C) 2021, Mariusz Postol LODZ POLAND. +// Copyright (C) 2022, Mariusz Postol LODZ POLAND. // // To be in touch join the community at GitHub: https://github.com/mpostol/OPC-UA-OOI/discussions //__________________________________________________________________________________________________ @@ -155,7 +155,7 @@ void IUANodeBase.CalculateNodeReferences(INodeFactory nodeFactory, IValidator va switch (_rfx.ReferenceKind) { case ReferenceKindEnum.Custom: - //TODO NetworkIdentifier is missing in generated Model Design for DI model #51 + //TODO NetworkIdentifier is missing in generated Model Design for DI model #629 XmlQualifiedName _ReferenceType = _rfx.GetReferenceTypeName(); if (_ReferenceType == XmlQualifiedName.Empty) { @@ -191,6 +191,7 @@ void IUANodeBase.CalculateNodeReferences(INodeFactory nodeFactory, IValidator va IsProperty = _rfx.TargetNode.IsPropertyVariableType; break; case ReferenceKindEnum.HierarchicalReferences: + //TODO NetworkIdentifier is missing in generated Model Design for DI model #629 throw new ArgumentOutOfRangeException($"the {nameof(ReferenceKindEnum.HierarchicalReferences)} is not handled"); } } @@ -275,7 +276,7 @@ public XmlQualifiedName ExportBrowseNameBaseType(Action traceEvent) /// /// Dictionary<System.String, IUANodeBase>. /// Circular loop in inheritance chain - //TODO NetworkIdentifier is missing in generated Model Design for DI model #51 + //TODO NetworkIdentifier is missing in generated Model Design for DI model #629 public Dictionary GetDerivedInstances() { if (m_InGetDerivedInstances) diff --git a/SemanticData/UANodeSetValidation/UAReferenceContext.cs b/SemanticData/UANodeSetValidation/UAReferenceContext.cs index 3f1bdf38..cdeb996f 100644 --- a/SemanticData/UANodeSetValidation/UAReferenceContext.cs +++ b/SemanticData/UANodeSetValidation/UAReferenceContext.cs @@ -1,9 +1,9 @@ -//___________________________________________________________________________________ +//__________________________________________________________________________________________________ // -// Copyright (C) 2021, Mariusz Postol LODZ POLAND. +// Copyright (C) 2022, Mariusz Postol LODZ POLAND. // -// To be in touch join the community at GITTER: https://gitter.im/mpostol/OPC-UA-OOI -//___________________________________________________________________________________ +// To be in touch join the community at GitHub: https://github.com/mpostol/OPC-UA-OOI/discussions +//__________________________________________________________________________________________________ using System; using System.Collections.Generic; @@ -22,7 +22,6 @@ namespace UAOOI.SemanticData.UANodeSetValidation /// internal class UAReferenceContext { - #region constructor internal UAReferenceContext(Reference reference, IAddressSpaceBuildContext addressSpaceContext, IUANodeContext parentNode) @@ -49,7 +48,7 @@ internal UAReferenceContext(Reference reference, IAddressSpaceBuildContext addre /// Gets the kind of the reference. /// /// The kind of the reference. - //TODO NetworkIdentifier is missing in generated Model Design for DI model #51 + //TODO NetworkIdentifier is missing in generated Model Design for DI model #629 internal ReferenceKindEnum ReferenceKind { get @@ -87,7 +86,7 @@ internal ReferenceKindEnum ReferenceKind /// Gets a value indicating whether the reference has been derived form or . /// /// true if it is child reference; otherwise, false. - //TODO NetworkIdentifier is missing in generated Model Design for DI model #51 + //TODO NetworkIdentifier is missing in generated Model Design for DI model #629 internal bool ChildConnector => (ReferenceKind == ReferenceKindEnum.HasProperty) || (ReferenceKind == ReferenceKindEnum.HasComponent); #endregion semantics