Skip to content

Commit

Permalink
NetworkIdentifier is missing in generated Model Design for DI model #629
Browse files Browse the repository at this point in the history


- fixed anchor id - unimportant changes
  • Loading branch information
mpostol committed Mar 9, 2022
1 parent e73d3a4 commit b64d3ef
Show file tree
Hide file tree
Showing 3 changed files with 12 additions and 12 deletions.
4 changes: 2 additions & 2 deletions SemanticData/UANodeSetValidation/AddressSpaceContext.cs
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
//__________________________________________________________________________________________________
//
// Copyright (C) 2021, Mariusz Postol LODZ POLAND.
// Copyright (C) 2022, Mariusz Postol LODZ POLAND.
//
// To be in touch join the community at GitHub: https://github.com/mpostol/OPC-UA-OOI/discussions
//__________________________________________________________________________________________________
Expand Down Expand Up @@ -217,7 +217,7 @@ IEnumerable<UAReferenceContext> IAddressSpaceBuildContext.GetReferences2Me(IUANo
/// </summary>
/// <param name="node">The root node of the requested children.</param>
/// <returns>Return an instance of <see cref="IEnumerable{IUANodeBase}" /> capturing all children of the selected node.</returns>
//TODO NetworkIdentifier is missing in generated Model Design for DI model #51
//TODO NetworkIdentifier is missing in generated Model Design for DI model #629
public IEnumerable<IUANodeBase> GetChildren(IUANodeBase node)
{
return m_References.Values.Where<UAReferenceContext>(x => Object.ReferenceEquals(x.SourceNode, node)).
Expand Down
7 changes: 4 additions & 3 deletions SemanticData/UANodeSetValidation/UANodeContext.cs
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
//__________________________________________________________________________________________________
//
// Copyright (C) 2021, Mariusz Postol LODZ POLAND.
// Copyright (C) 2022, Mariusz Postol LODZ POLAND.
//
// To be in touch join the community at GitHub: https://github.com/mpostol/OPC-UA-OOI/discussions
//__________________________________________________________________________________________________
Expand Down Expand Up @@ -155,7 +155,7 @@ void IUANodeBase.CalculateNodeReferences(INodeFactory nodeFactory, IValidator va
switch (_rfx.ReferenceKind)
{
case ReferenceKindEnum.Custom:
//TODO NetworkIdentifier is missing in generated Model Design for DI model #51
//TODO NetworkIdentifier is missing in generated Model Design for DI model #629
XmlQualifiedName _ReferenceType = _rfx.GetReferenceTypeName();
if (_ReferenceType == XmlQualifiedName.Empty)
{
Expand Down Expand Up @@ -191,6 +191,7 @@ void IUANodeBase.CalculateNodeReferences(INodeFactory nodeFactory, IValidator va
IsProperty = _rfx.TargetNode.IsPropertyVariableType;
break;
case ReferenceKindEnum.HierarchicalReferences:
//TODO NetworkIdentifier is missing in generated Model Design for DI model #629
throw new ArgumentOutOfRangeException($"the {nameof(ReferenceKindEnum.HierarchicalReferences)} is not handled");
}
}
Expand Down Expand Up @@ -275,7 +276,7 @@ public XmlQualifiedName ExportBrowseNameBaseType(Action<NodeId> traceEvent)
/// </summary>
/// <returns>Dictionary&lt;System.String, IUANodeBase&gt;.</returns>
/// <exception cref="ArgumentOutOfRangeException">Circular loop in inheritance chain</exception>
//TODO NetworkIdentifier is missing in generated Model Design for DI model #51
//TODO NetworkIdentifier is missing in generated Model Design for DI model #629
public Dictionary<string, IUANodeBase> GetDerivedInstances()
{
if (m_InGetDerivedInstances)
Expand Down
13 changes: 6 additions & 7 deletions SemanticData/UANodeSetValidation/UAReferenceContext.cs
Original file line number Diff line number Diff line change
@@ -1,9 +1,9 @@
//___________________________________________________________________________________
//__________________________________________________________________________________________________
//
// Copyright (C) 2021, Mariusz Postol LODZ POLAND.
// Copyright (C) 2022, Mariusz Postol LODZ POLAND.
//
// To be in touch join the community at GITTER: https://gitter.im/mpostol/OPC-UA-OOI
//___________________________________________________________________________________
// To be in touch join the community at GitHub: https://github.com/mpostol/OPC-UA-OOI/discussions
//__________________________________________________________________________________________________

using System;
using System.Collections.Generic;
Expand All @@ -22,7 +22,6 @@ namespace UAOOI.SemanticData.UANodeSetValidation
/// </summary>
internal class UAReferenceContext
{

#region constructor

internal UAReferenceContext(Reference reference, IAddressSpaceBuildContext addressSpaceContext, IUANodeContext parentNode)
Expand All @@ -49,7 +48,7 @@ internal UAReferenceContext(Reference reference, IAddressSpaceBuildContext addre
/// Gets the kind of the reference.
/// </summary>
/// <value>The kind of the reference.</value>
//TODO NetworkIdentifier is missing in generated Model Design for DI model #51
//TODO NetworkIdentifier is missing in generated Model Design for DI model #629
internal ReferenceKindEnum ReferenceKind
{
get
Expand Down Expand Up @@ -87,7 +86,7 @@ internal ReferenceKindEnum ReferenceKind
/// Gets a value indicating whether the reference has been derived form <see cref="ReferenceKindEnum.HasProperty"/> or <see cref="ReferenceKindEnum.HasComponent"/>.
/// </summary>
/// <value><c>true</c> if it is child reference; otherwise, <c>false</c>.</value>
//TODO NetworkIdentifier is missing in generated Model Design for DI model #51
//TODO NetworkIdentifier is missing in generated Model Design for DI model #629
internal bool ChildConnector => (ReferenceKind == ReferenceKindEnum.HasProperty) || (ReferenceKind == ReferenceKindEnum.HasComponent);

#endregion semantics
Expand Down

1 comment on commit b64d3ef

@mpostol
Copy link
Owner Author

@mpostol mpostol commented on b64d3ef Mar 9, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It contributes to mpostol/UA-Nodeset#51

Please sign in to comment.