Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Confusing output when code is compiling when running with "make --watch" #128

Open
jfmengels opened this issue Jul 18, 2023 · 1 comment
Labels
help wanted Extra attention is needed

Comments

@jfmengels
Copy link

When running elm-test-rs make --watch, the output when the code is compiling is a bit unhelpful.

  1. If you start running it when code compiles, it looks like it’s hanging (but it’s still doing things or it’s done). I would expect a message such as "Success! Compiled N modules." or just "Success!" to have some feedback and not feeling like the tool is in an infinite loop.

  2. If after a change it’s compiling, then you have a large chunk of empty lines

Change detected in tests/Humio/Page/RepoOrView/SearchPage/FieldInteractionsTest.elm
===================================================================================








Change detected in tests/Humio/Page/RepoOrView/SearchPage/FieldInteractionsTest.elm
===================================================================================



I am not sure that these separators and blank spaces are worth having in this mode. Again, I would add a "Success!" message of some sorts at least.

@mpizenberg
Copy link
Owner

mpizenberg commented Jul 18, 2023

Thanks for the issue!

The blank space is useful when showing errors, to easily differentiate errors you already fixed (in previous output) from the ones of the current compilation.

I agree that showing nothing but blank space when there is no error is not helpful however as you don’t know if it’s done or doing. I guess I didn’t take into account cases where the code base could take long to compile.

@mpizenberg mpizenberg added the help wanted Extra attention is needed label Jul 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants