Skip to content
This repository has been archived by the owner on Jul 22, 2024. It is now read-only.

Add optional audio gesture intent paramenter #996

Merged
merged 2 commits into from
Mar 18, 2019
Merged

Conversation

MortimerGoro
Copy link
Contributor

No description provided.

@ghost ghost assigned MortimerGoro Mar 11, 2019
@ghost ghost added the in progress label Mar 11, 2019
@bluemarvin
Copy link
Contributor

We are going to loose the ability to set prefs this way soon.

@fernandojsg
Copy link

@bluemarvin does it mean that another way to implement that behaviour should be implemented? or that it will be impossible to set these prefs? :\

@bluemarvin
Copy link
Contributor

@bluemarvin does it mean that another way to implement that behaviour should be implemented? or that it will be impossible to set these prefs? :\

The plan is to remove setting prefs in GV. I'll make sure it doesn't happen until we have a way to support what you need. One thing that we do in GV test is use the remote debugging protocol to set prefs. Would it be possible for the performance tests to use it as well?

@fernandojsg
Copy link

@bluemarvin does it mean that another way to implement that behaviour should be implemented? or that it will be impossible to set these prefs? :\

The plan is to remove setting prefs in GV. I'll make sure it doesn't happen until we have a way to support what you need. One thing that we do in GV test is use the remote debugging protocol to set prefs. Would it be possible for the performance tests to use it as well?

Not sure how that works, could you provide me some example o link to doc to understand what should I do in order to set the prefs that way?

@bluemarvin
Copy link
Contributor

Not sure how that works, could you provide me some example o link to doc to understand what should I do in order to set the prefs that way?

Looks like it might be a little involved unfortunately. This is the documentation for the Remote Debugging Protocol. And the Java code that uses the protocol for GeckoView tests. Snorp found this: Foxdriver but looks like it might be abandoned. I might be able to help write some infrastructure to help make this easier. Just need to figure out what the best strategy is. Maybe we should create an issue some where and continue the conversation there.

@fernandojsg
Copy link

@MortimerGoro is this anyhow different to the same option on firefox desktop? I tried to set it there
image
and I got the same error on the demo https://fernandojsg.github.io/cruciform/?play&quality=low

NotAllowedError: The play method is not allowed by the user agent or the platform in the current context, possibly because the user denied permission.

@fernandojsg
Copy link

Not sure how that works, could you provide me some example o link to doc to understand what should I do in order to set the prefs that way?

Looks like it might be a little involved unfortunately. This is the documentation for the Remote Debugging Protocol. And the Java code that uses the protocol for GeckoView tests. Snorp found this: Foxdriver but looks like it might be abandoned. I might be able to help write some infrastructure to help make this easier. Just need to figure out what the best strategy is. Maybe we should create an issue some where and continue the conversation there.

Yep, I'll create an issue and we could move the discussion there 👍

@fernandojsg
Copy link

fwiw in chrome is working correctly using this flag
image

@MortimerGoro
Copy link
Contributor Author

MortimerGoro commented Mar 14, 2019

@fernandojsg I handled more preferences so you can test this again.

You need to change the param name to media.autoplay.enabled

@philip-lamb philip-lamb added this to the v1.2 milestone Mar 15, 2019
@fernandojsg
Copy link

I tried it and work correctly with the latest changes

@MortimerGoro MortimerGoro merged commit bfb803d into master Mar 18, 2019
@ghost ghost removed the in progress label Mar 18, 2019
@cvan cvan deleted the audio_gesture branch March 18, 2019 23:27
@cvan cvan modified the milestones: v1.2, v1.1.4, v1.1.3 Apr 11, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants