This repository has been archived by the owner on Jul 22, 2024. It is now read-only.
Add support for arm64-v8a on GoogleVR, Oculus and SVR #949
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The title confused me, I didn't think Wave had 64 bit libs. Should be GVR instead of Wave 🙂 |
bluemarvin
changed the title
bluemarvin
reviewed
Feb 14, 2019
| 'svrArmDebug', | ||
| 'svrArmRelease', | ||
| 'svrArm64Debug', | ||
| 'svrArm64Release', | ||
| 'wavevrArmDebug', | ||
| 'wavevrArmRelease', | ||
| 'noapiArmDebug', |
There was a problem hiding this comment.
Can you add noapiArm64[Debug,Release] also?
MortimerGoro
force-pushed
the
arm64-v8a
branch
from
b11b9d2 to
afee2cd
Compare
bluemarvin
approved these changes
Feb 14, 2019
|
I also updated the GeckoView version. Today's 64bit nighlty showed much more performance on https://threejs.org/examples/webvr_ballshooter.html
Yep, the mistake was only on the commit description 😅 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.