Skip to content
This repository has been archived by the owner on Jul 22, 2024. It is now read-only.

Fixes #887 Merge localpages.xml and strings.xml #894

Merged
merged 5 commits into from
Dec 17, 2018
Merged

Conversation

keianhzo
Copy link
Contributor

Fixes #887 Merge localpages.xml and strings.xml

@keianhzo keianhzo requested review from Delphine and Pike December 14, 2018 22:45
Copy link
Contributor

@Pike Pike left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sweet, thanks.

Only nit is the trailing newline in the l10n.toml file.

l10n.toml Outdated Show resolved Hide resolved
Copy link
Contributor

@cvan cvan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested, and works 👍

thank you, @keianhzo and @Pike!

app/src/main/res/values-it/strings.xml Outdated Show resolved Hide resolved
app/src/main/res/values-ja/strings.xml Show resolved Hide resolved
app/src/main/res/values-zh-rTW/strings.xml Show resolved Hide resolved
Copy link

@Delphine Delphine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! thanks for doing this!

@keianhzo keianhzo merged commit b230f01 into master Dec 17, 2018
@cvan cvan deleted the merge-localpages branch December 17, 2018 17:26
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants