-
Notifications
You must be signed in to change notification settings - Fork 218
Oculus VR multiple controllers support #886
Oculus VR multiple controllers support #886
Conversation
60f7157
to
c47c731
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We updated to use KTX for textures. There are now instructions for converting. Please update the controller models to use compressed textures.
c47c731
to
91e45e3
Compare
Replaced the model's texture to be KTX. |
@MortimerGoro @bluemarvin I think it is ready to continue to review. |
91e45e3
to
99a84d7
Compare
@MortimerGoro please help review my reply. Thanks! |
99a84d7
to
f654725
Compare
@MortimerGoro I think all the requests are resolved! Thanks. |
f654725
to
89c551a
Compare
The log from Taskcluster is odd. I don't know what's wrong with the server.
|
@daoshengmu have you tried a rebase? |
89c551a
to
ca235ba
Compare
@MortimerGoro I already tried. I also tried to apply my patches with a new branch as #924. @bluemarvin Do you know why Taskcluster's tasks failed recently? |
The problem is Google broke the Daydream NDK extract. Trying to find a solution. May have to stop building on automation short term. May need to fork the NDK and fix the gradle files until google gets around to it. |
Merging this, the taskcluster issue is not related to this PR |
In this PR, we would like to support multiple 6DOF controllers in Oculus. I have added this new controller model to the asset folder and help Oculus VR enumerates new controllers at runtime to update controller's status.
Besides, I also expand ExternalVR to provide 6DOF controller experience in WebVR immersive mode. I have verified it would work properly in the examples from http://webvr.info/ and https://hubs.mozilla.com/, it is very close to the quality as Oculus Rift in FF desktop.