Skip to content
This repository has been archived by the owner on Jul 22, 2024. It is now read-only.

Don't remember fullscreen resize on restart #856

Merged
merged 1 commit into from
Nov 27, 2018

Conversation

MortimerGoro
Copy link
Contributor

Fixes #839

@bluemarvin
Copy link
Contributor

Shouldn't both browser window size and fullscreen window size be saved seperately? Maybe just a scale factor for fullscreen since we resize based on video aspect ratio? Probably should be considered when the window resize refactor work is done.

@bluemarvin bluemarvin merged commit 9e66e70 into master Nov 27, 2018
@bluemarvin bluemarvin deleted the fullscreen_resize_store branch November 27, 2018 19:26
@cvan
Copy link
Contributor

cvan commented Nov 27, 2018

Shouldn't both browser window size and fullscreen window size be saved seperately? Maybe just a scale factor for fullscreen since we resize based on video aspect ratio? Probably should be considered when the window resize refactor work is done.

@caseyyee ^ thoughts?

@cvan cvan added this to the v1.1 milestone Nov 27, 2018
@cvan cvan added the bug This issue is a software or functional defect label Nov 27, 2018
@caseyyee
Copy link
Contributor

caseyyee commented Nov 28, 2018

I like the option of scaling the fullscreen window to any ratio. It's not just for video, even if that's the main use case.

As far as remembering the size goes, I think some proportion of the browser window size might work, but I can see this being a annoying inconsistency from a UX perspective as well.

Safest bet for now would be just to have a fixed starting size for fullscreen. It's how it works now, and I think it's pretty alright.

Just my 2c, as you can tell. Not totally decided yet. Still needs some thinking!

@bluemarvin
Copy link
Contributor

I'm pretty sure we are resizing the window based on the videos aspect ratio to prevent black bars. Am I wrong? I think fullscreen video resize should maintain the aspect ratio. Otherwise we are wasting pixels. Which would make it different from a normal window resize.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug This issue is a software or functional defect
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants