This repository has been archived by the owner on Jul 22, 2024. It is now read-only.
Added a Java global exception handler #602
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
keianhzo
force-pushed
the
java-exception-handler
branch
3 times, most recently
from
5cd7c76 to
8bee8ba
Compare
keianhzo
force-pushed
the
java-exception-handler
branch
from
30d440b to
026b06a
Compare
bluemarvin
approved these changes
Oct 3, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #592 Set a global Java exception handler using Gecko's CrashHandler implementation. Should catch any exception including OOMs happening in any thread from the current process.
Regarding @cvan's comment on #592 the CrashHandler seems to be sending reports to https://crash-reports.mozilla.com/, not sure if that's the right place for it or we should extend that to use another endpoint (he mentioned Sentry).