Skip to content
This repository has been archived by the owner on Jul 22, 2024. It is now read-only.

Add support for MSAA selection in dev setting. Default MSAA to 2x. #579

Merged
merged 1 commit into from
Sep 27, 2018
Merged

Add support for MSAA selection in dev setting. Default MSAA to 2x. #579

merged 1 commit into from
Sep 27, 2018

Conversation

MortimerGoro
Copy link
Contributor

No description provided.

@MortimerGoro
Copy link
Contributor Author

I tested performance on some webs. I didn't notice perf dropdowns on the demos I tried, but a very noticeable quality improvement.

Some example data from WebVR playcanvas lab on the Go:

PlayCanvas Lab: No msaa

07:16:14.963 22499-22655/org.mozilla.vrbrowser I/VrApi: FPS=60,Prd=31ms,Tear=0,Early=0,Stale=2,VSnc=1,Lat=0,Fov=0,CPU2/GPU=4/4,1593/510MHz,OC=F,TA=E/C/C,SP=N/N/N,Mem=1554MHz,Free=758MB,PSM=0,PLS=0,Temp=28.5C/25.0C,TW=0.89ms,App=3.88ms
09-26 07:16:15.962 22499-22655/org.mozilla.vrbrowser I/VrApi: FPS=45,Prd=27ms,Tear=0,Early=0,Stale=36,VSnc=1,Lat=0,Fov=0,CPU2/GPU=4/4,1593/510MHz,OC=F,TA=E/C/C,SP=N/N/N,Mem=1554MHz,Free=758MB,PSM=0,PLS=0,Temp=28.5C/25.0C,TW=0.94ms,App=3.20ms
09-26 07:16:16.965 22499-22655/org.mozilla.vrbrowser I/VrApi: FPS=18,Prd=18ms,Tear=0,Early=0,Stale=61,VSnc=1,Lat=0,Fov=0,CPU2/GPU=4/4,1593/510MHz,OC=F,TA=E/C/C,SP=N/N/N,Mem=1554MHz,Free=778MB,PSM=0,PLS=0,Temp=28.5C/25.0C,TW=0.97ms,App=7.20ms
09-26 07:16:17.963 22499-22655/org.mozilla.vrbrowser I/VrApi: FPS=21,Prd=33ms,Tear=0,Early=0,Stale=60,VSnc=1,Lat=0,Fov=0,CPU2/GPU=4/4,1593/510MHz,OC=F,TA=E/C/C,SP=N/N/N,Mem=1554MHz,Free=784MB,PSM=0,PLS=0,Temp=28.5C/25.0C,TW=0.94ms,App=5.85ms
09-26 07:16:18.965 22499-22655/org.mozilla.vrbrowser I/VrApi: FPS=28,Prd=34ms,Tear=0,Early=0,Stale=61,VSnc=1,Lat=0,Fov=0,CPU2/GPU=4/4,1593/510MHz,OC=F,TA=E/C/C,SP=N/N/N,Mem=1554MHz,Free=784MB,PSM=0,PLS=0,Temp=28.5C/25.0C,TW=0.95ms,App=7.54ms
09-26 07:16:19.967 22499-22655/org.mozilla.vrbrowser I/VrApi: FPS=28,Prd=32ms,Tear=0,Early=0,Stale=60,VSnc=1,Lat=0,Fov=0,CPU2/GPU=4/4,1593/510MHz,OC=F,TA=E/C/C,SP=N/N/N,Mem=1017MHz,Free=810MB,PSM=0,PLS=0,Temp=28.5C/25.0C,TW=1.02ms,App=7.58ms
09-26 07:16:20.966 22499-22655/org.mozilla.vrbrowser I/VrApi: FPS=32,Prd=33ms,Tear=0,Early=0,Stale=62,VSnc=1,Lat=0,Fov=0,CPU2/GPU=4/4,1593/510MHz,OC=F,TA=E/C/C,SP=N/N/N,Mem=1017MHz,Free=811MB,PSM=0,PLS=0,Temp=28.5C/25.0C,TW=1.11ms,App=8.57ms
09-26 07:16:21.967 22499-22655/org.mozilla.vrbrowser I/VrApi: FPS=37,Prd=32ms,Tear=0,Early=0,Stale=60,VSnc=1,Lat=0,Fov=0,CPU2/GPU=4/4,1593/510MHz,OC=F,TA=E/C/C,SP=N/N/N,Mem=1017MHz,Free=811MB,PSM=0,PLS=0,Temp=28.5C/25.0C,TW=1.06ms,App=8.16ms
09-26 07:16:22.968 22499-22655/org.mozilla.vrbrowser I/VrApi: FPS=38,Prd=35ms,Tear=0,Early=0,Stale=57,VSnc=1,Lat=0,Fov=0,CPU2/GPU=4/4,1593/510MHz,OC=F,TA=E/C/C,SP=N/N/N,Mem=1017MHz,Free=811MB,PSM=0,PLS=0,Temp=28.5C/25.0C,TW=1.10ms,App=8.95ms
09-26 07:16:23.964 22499-22655/org.mozilla.vrbrowser I/VrApi: FPS=40,Prd=33ms,Tear=0,Early=0,Stale=60,VSnc=1,Lat=0,Fov=0,CPU2/GPU=4/4,1593/510MHz,OC=F,TA=E/C/C,SP=N/N/N,Mem=1017MHz,Free=811MB,PSM=0,PLS=0,Temp=28.5C/25.0C,TW=1.11ms,App=8.83ms
09-26 07:16:24.967 22499-22655/org.mozilla.vrbrowser I/VrApi: FPS=38,Prd=33ms,Tear=0,Early=0,Stale=60,VSnc=1,Lat=0,Fov=0,CPU2/GPU=4/4,1593/510MHz,OC=F,TA=E/C/C,SP=N/N/N,Mem=1017MHz,Free=811MB,PSM=0,PLS=0,Temp=28.5C/25.0C,TW=1.11ms,App=8.81ms
09-26 07:16:25.965 22499-22655/org.mozilla.vrbrowser I/VrApi: FPS=40,Prd=32ms,Tear=0,Early=0,Stale=58,VSnc=1,Lat=0,Fov=0,CPU2/GPU=4/4,1593/510MHz,OC=F,TA=E/C/C,SP=N/N/N,Mem=1017MHz,Free=809MB,PSM=0,PLS=0,Temp=28.5C/25.0C,TW=1.10ms,App=8.64ms
09-26 07:16:26.966 22499-22655/org.mozilla.vrbrowser I/VrApi: FPS=41,Prd=33ms,Tear=0,Early=0,Stale=59,VSnc=1,Lat=0,Fov=0,CPU2/GPU=4/4,1593/510MHz,OC=F,TA=E/C/C,SP=N/N/N,Mem=1017MHz,Free=809MB,PSM=0,PLS=0,Temp=28.5C/25.0C,TW=1.16ms,App=9.30ms
09-26 07:16:27.964 22499-22655/org.mozilla.vrbrowser I/VrApi: FPS=39,Prd=33ms,Tear=0,Early=0,Stale=56,VSnc=1,Lat=0,Fov=0,CPU2/GPU=4/4,1593/510MHz,OC=F,TA=E/C/C,SP=N/N/N,Mem=1017MHz,Free=809MB,PSM=0,PLS=0,Temp=28.5C/25.0C,TW=1.07ms,App=8.53ms
09-26 07:16:28.966 22499-22655/org.mozilla.vrbrowser I/VrApi: FPS=39,Prd=34ms,Tear=0,Early=0,Stale=59,VSnc=1,Lat=0,Fov=0,CPU2/GPU=4/4,1593/510MHz,OC=F,TA=E/C/C,SP=N/N/N,Mem=1017MHz,Free=809MB,PSM=0,PLS=0,Temp=28.5C/25.0C,TW=1.08ms,App=7.99ms
09-26 07:16:29.966 22499-22655/org.mozilla.vrbrowser I/VrApi: FPS=40,Prd=33ms,Tear=0,Early=0,Stale=60,VSnc=1,Lat=0,Fov=0,CPU2/GPU=4/4,1593/510MHz,OC=F,TA=E/C/C,SP=N/N/N,Mem=1017MHz,Free=809MB,PSM=0,PLS=0,Temp=28.5C/25.0C,TW=1.11ms,App=9.09ms
09-26 07:16:30.966 22499-22655/org.mozilla.vrbrowser I/VrApi: FPS=41,Prd=32ms,Tear=0,Early=0,Stale=59,VSnc=1,Lat=0,Fov=0,CPU2/GPU=4/4,1593/510MHz,OC=F,TA=E/C/C,SP=N/N/N,Mem=1017MHz,Free=809MB,PSM=0,PLS=0,Temp=28.5C/25.0C,TW=1.08ms,App=8.59ms
09-26 07:16:31.970 22499-22655/org.mozilla.vrbrowser I/VrApi: FPS=41,Prd=33ms,Tear=0,Early=0,Stale=56,VSnc=1,Lat=0,Fov=0,CPU2/GPU=4/4,1593/510MHz,OC=F,TA=E/C/C,SP=N/N/N,Mem=1017MHz,Free=808MB,PSM=0,PLS=0,Temp=28.5C/25.0C,TW=1.10ms,App=8.87ms
09-26 07:16:32.971 22499-22655/org.mozilla.vrbrowser I/VrApi: FPS=41,Prd=32ms,Tear=0,Early=0,Stale=59,VSnc=1,Lat=0,Fov=0,CPU2/GPU=4/4,1593/510MHz,OC=F,TA=E/C/C,SP=N/N/N,Mem=1017MHz,Free=808MB,PSM=0,PLS=0,Temp=28.5C/25.0C,TW=1.20ms,App=8.69ms
09-26 07:16:33.967 22499-22655/org.mozilla.vrbrowser I/VrApi: FPS=40,Prd=33ms,Tear=0,Early=0,Stale=57,VSnc=1,Lat=0,Fov=0,CPU2/GPU=4/4,1593/510MHz,OC=F,TA=E/C/C,SP=N/N/N,Mem=1017MHz,Free=808MB,PSM=0,PLS=0,Temp=28.5C/25.0C,TW=1.08ms,App=8.74ms
09-26 07:16:34.968 22499-22655/org.mozilla.vrbrowser I/VrApi: FPS=41,Prd=33ms,Tear=0,Early=0,Stale=57,VSnc=1,Lat=0,Fov=0,CPU2/GPU=4/4,1593/510MHz,OC=F,TA=E/C/C,SP=N/N/N,Mem=1554MHz,Free=807MB,PSM=0,PLS=0,Temp=28.5C/25.0C,TW=1.10ms,App=8.55ms
09-26 07:16:35.965 22499-22655/org.mozilla.vrbrowser I/VrApi: FPS=41,Prd=33ms,Tear=0,Early=0,Stale=59,VSnc=1,Lat=0,Fov=0,CPU2/GPU=4/4,1593/510MHz,OC=F,TA=E/C/C,SP=N/N/N,Mem=1017MHz,Free=807MB,PSM=0,PLS=0,Temp=28.5C/25.0C,TW=1.06ms,App=7.49ms
09-26 07:16:36.967 22499-22655/org.mozilla.vrbrowser I/VrApi: FPS=44,Prd=33ms,Tear=0,Early=0,Stale=57,VSnc=1,Lat=0,Fov=0,CPU2/GPU=4/4,1593/510MHz,OC=F,TA=E/C/C,SP=N/N/N,Mem=1296MHz,Free=817MB,PSM=0,PLS=0,Temp=28.5C/25.0C,TW=1.07ms,App=7.02ms
09-26 07:16:37.965 22499-22655/org.mozilla.vrbrowser I/VrApi: FPS=26,Prd=33ms,Tear=0,Early=0,Stale=61,VSnc=1,Lat=0,Fov=0,CPU2/GPU=4/4,1593/510MHz,OC=F,TA=E/C/C,SP=N/N/N,Mem=1296MHz,Free=818MB,PSM=0,PLS=0,Temp=28.5C/25.0C,TW=1.00ms,App=5.13ms

PlayCanvas Lab: 2x

09-26 07:20:31.191 22870-23231/org.mozilla.vrbrowser I/VrApi: FPS=38,Prd=34ms,Tear=0,Early=0,Stale=51,VSnc=1,Lat=0,Fov=0,CPU2/GPU=4/4,1593/510MHz,OC=F,TA=E/C/C,SP=N/N/N,Mem=1296MHz,Free=812MB,PSM=0,PLS=0,Temp=29.0C/25.0C,TW=1.09ms,App=5.95ms
09-26 07:20:32.191 22870-23231/org.mozilla.vrbrowser I/VrApi: FPS=39,Prd=33ms,Tear=0,Early=0,Stale=56,VSnc=1,Lat=0,Fov=0,CPU2/GPU=4/4,1593/510MHz,OC=F,TA=E/C/C,SP=N/N/N,Mem=1296MHz,Free=821MB,PSM=0,PLS=0,Temp=29.0C/25.0C,TW=1.04ms,App=5.61ms
09-26 07:20:33.195 22870-23231/org.mozilla.vrbrowser I/VrApi: FPS=44,Prd=33ms,Tear=0,Early=0,Stale=50,VSnc=1,Lat=0,Fov=0,CPU2/GPU=4/4,1593/510MHz,OC=F,TA=E/C/C,SP=N/N/N,Mem=1017MHz,Free=827MB,PSM=0,PLS=0,Temp=29.0C/25.0C,TW=1.04ms,App=6.04ms
09-26 07:20:34.192 22870-23231/org.mozilla.vrbrowser I/VrApi: FPS=36,Prd=33ms,Tear=0,Early=0,Stale=57,VSnc=1,Lat=0,Fov=0,CPU2/GPU=4/4,1593/510MHz,OC=F,TA=E/C/C,SP=N/N/N,Mem=1017MHz,Free=827MB,PSM=0,PLS=0,Temp=29.0C/25.0C,TW=1.08ms,App=5.92ms
09-26 07:20:35.193 22870-23231/org.mozilla.vrbrowser I/VrApi: FPS=40,Prd=33ms,Tear=0,Early=0,Stale=54,VSnc=1,Lat=0,Fov=0,CPU2/GPU=4/4,1593/510MHz,OC=F,TA=E/C/C,SP=N/N/N,Mem=1017MHz,Free=827MB,PSM=0,PLS=0,Temp=29.5C/25.0C,TW=1.04ms,App=5.47ms
09-26 07:20:36.196 22870-23231/org.mozilla.vrbrowser I/VrApi: FPS=39,Prd=33ms,Tear=0,Early=0,Stale=54,VSnc=1,Lat=0,Fov=0,CPU2/GPU=4/4,1593/510MHz,OC=F,TA=E/C/C,SP=N/N/N,Mem=1017MHz,Free=830MB,PSM=0,PLS=0,Temp=29.5C/25.0C,TW=1.08ms,App=5.54ms
09-26 07:20:37.195 22870-23231/org.mozilla.vrbrowser I/VrApi: FPS=41,Prd=34ms,Tear=0,Early=0,Stale=53,VSnc=1,Lat=0,Fov=0,CPU2/GPU=4/4,1593/510MHz,OC=F,TA=E/C/C,SP=N/N/N,Mem=1017MHz,Free=830MB,PSM=0,PLS=0,Temp=29.5C/25.0C,TW=1.11ms,App=5.23ms
09-26 07:20:38.195 22870-23231/org.mozilla.vrbrowser I/VrApi: FPS=44,Prd=33ms,Tear=0,Early=0,Stale=55,VSnc=1,Lat=0,Fov=0,CPU2/GPU=4/4,1593/510MHz,OC=F,TA=E/C/C,SP=N/N/N,Mem=1017MHz,Free=829MB,PSM=0,PLS=0,Temp=29.5C/25.0C,TW=1.09ms,App=5.99ms
09-26 07:20:39.194 22870-23231/org.mozilla.vrbrowser I/VrApi: FPS=43,Prd=33ms,Tear=0,Early=0,Stale=53,VSnc=1,Lat=0,Fov=0,CPU2/GPU=4/4,1593/510MHz,OC=F,TA=E/C/C,SP=N/N/N,Mem=1017MHz,Free=829MB,PSM=0,PLS=0,Temp=29.5C/25.0C,TW=1.11ms,App=5.78ms
09-26 07:20:40.197 22870-23231/org.mozilla.vrbrowser I/VrApi: FPS=42,Prd=35ms,Tear=0,Early=0,Stale=49,VSnc=1,Lat=0,Fov=0,CPU2/GPU=4/4,1593/510MHz,OC=F,TA=E/C/C,SP=N/N/N,Mem=1017MHz,Free=829MB,PSM=0,PLS=0,Temp=29.5C/25.0C,TW=1.11ms,App=6.13ms
09-26 07:20:41.194 22870-23231/org.mozilla.vrbrowser I/VrApi: FPS=41,Prd=33ms,Tear=0,Early=0,Stale=55,VSnc=1,Lat=0,Fov=0,CPU2/GPU=4/4,1593/510MHz,OC=F,TA=E/C/C,SP=N/N/N,Mem=1017MHz,Free=829MB,PSM=0,PLS=0,Temp=29.5C/25.0C,TW=1.10ms,App=5.79ms
09-26 07:20:42.201 22870-23231/org.mozilla.vrbrowser I/VrApi: FPS=41,Prd=33ms,Tear=0,Early=0,Stale=56,VSnc=1,Lat=0,Fov=0,CPU2/GPU=4/4,1593/510MHz,OC=F,TA=E/C/C,SP=N/N/N,Mem=1017MHz,Free=829MB,PSM=0,PLS=0,Temp=29.5C/25.0C,TW=1.09ms,App=5.79ms
09-26 07:20:43.199 22870-23231/org.mozilla.vrbrowser I/VrApi: FPS=38,Prd=33ms,Tear=0,Early=0,Stale=53,VSnc=1,Lat=0,Fov=0,CPU2/GPU=4/4,1593/510MHz,OC=F,TA=E/C/C,SP=N/N/N,Mem=1017MHz,Free=829MB,PSM=0,PLS=0,Temp=29.5C/25.0C,TW=1.09ms,App=5.85ms
09-26 07:20:44.211 22870-23231/org.mozilla.vrbrowser I/VrApi: FPS=39,Prd=34ms,Tear=0,Early=0,Stale=54,VSnc=1,Lat=0,Fov=0,CPU2/GPU=4/4,1593/510MHz,OC=F,TA=E/C/C,SP=N/N/N,Mem=1017MHz,Free=829MB,PSM=0,PLS=0,Temp=29.5C/25.0C,TW=1.10ms,App=6.11ms
09-26 07:20:45.198 22870-23231/org.mozilla.vrbrowser I/VrApi: FPS=44,Prd=34ms,Tear=0,Early=0,Stale=52,VSnc=1,Lat=0,Fov=0,CPU2/GPU=4/4,1593/510MHz,OC=F,TA=E/C/C,SP=N/N/N,Mem=1017MHz,Free=829MB,PSM=0,PLS=0,Temp=29.2C/25.0C,TW=1.10ms,App=5.77ms
09-26 07:20:46.202 22870-23231/org.mozilla.vrbrowser I/VrApi: FPS=42,Prd=34ms,Tear=0,Early=0,Stale=56,VSnc=1,Lat=0,Fov=0,CPU2/GPU=4/4,1593/510MHz,OC=F,TA=E/C/C,SP=N/N/N,Mem=1017MHz,Free=827MB,PSM=0,PLS=0,Temp=29.2C/25.0C,TW=1.09ms,App=5.59ms
09-26 07:20:47.201 22870-23231/org.mozilla.vrbrowser I/VrApi: FPS=43,Prd=33ms,Tear=0,Early=0,Stale=53,VSnc=1,Lat=0,Fov=0,CPU2/GPU=4/4,1593/510MHz,OC=F,TA=E/C/C,SP=N/N/N,Mem=1017MHz,Free=831MB,PSM=0,PLS=0,Temp=29.2C/25.0C,TW=1.10ms,App=6.01ms
09-26 07:20:48.199 22870-23231/org.mozilla.vrbrowser I/VrApi: FPS=36,Prd=34ms,Tear=0,Early=0,Stale=55,VSnc=1,Lat=0,Fov=0,CPU2/GPU=4/4,1593/510MHz,OC=F,TA=E/C/C,SP=N/N/N,Mem=1017MHz,Free=845MB,PSM=0,PLS=0,Temp=29.2C/25.0C,TW=1.09ms,App=5.55ms
09-26 07:20:49.199 22870-23231/org.mozilla.vrbrowser I/VrApi: FPS=26,Prd=30ms,Tear=0,Early=0,Stale=60,VSnc=1,Lat=0,Fov=0,CPU2/GPU=4/4,1593/510MHz,OC=F,TA=E/C/C,SP=N/N/N,Mem=1017MHz,Free=844MB,PSM=0,PLS=0,Temp=29.2C/25.0C,TW=1.08ms,App=3.55ms
09-26 07:20:50.199 22870-23231/org.mozilla.vrbrowser I/VrApi: FPS=18,Prd=27ms,Tear=0,Early=0,Stale=63,VSnc=1,Lat=0,Fov=0,CPU2/GPU=4/4,1593/510MHz,OC=F,TA=E/C/C,SP=N/N/N,Mem=1017MHz,Free=844MB,PSM=0,PLS=0,Temp=29.2C/25.0C,TW=1.09ms,App=5.79ms
09-26 07:20:51.200 22870-23231/org.mozilla.vrbrowser I/VrApi: FPS=33,Prd=31ms,Tear=0,Early=0,Stale=61,VSnc=1,Lat=0,Fov=0,CPU2/GPU=4/4,1593/510MHz,OC=F,TA=E/C/C,SP=N/N/N,Mem=1017MHz,Free=843MB,PSM=0,PLS=0,Temp=29.2C/25.0C,TW=1.10ms,App=6.03ms
09-26 07:20:52.202 22870-23231/org.mozilla.vrbrowser I/VrApi: FPS=40,Prd=34ms,Tear=0,Early=0,Stale=55,VSnc=1,Lat=0,Fov=0,CPU2/GPU=4/4,1593/510MHz,OC=F,TA=E/C/C,SP=N/N/N,Mem=1017MHz,Free=834MB,PSM=0,PLS=0,Temp=29.2C/25.0C,TW=1.08ms,App=5.60ms

@bluemarvin
Copy link
Contributor

There should be a line between the the UA setting and MSAA setting.
screenshot_20180926_120129

bluemarvin
bluemarvin suggested changes Sep 26, 2018
View reviewed changes
Copy link
Contributor

@bluemarvin bluemarvin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! just add the missing divider.

keianhzo
keianhzo approved these changes Sep 27, 2018
View reviewed changes
Copy link
Contributor

@keianhzo keianhzo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@MortimerGoro MortimerGoro merged commit bd70ea7 into master Sep 27, 2018
@bluemarvin
Copy link
Contributor

Did the missing divider get added?

@MortimerGoro
Copy link
Contributor Author

Yes, forgot to comment that here

@bluemarvin bluemarvin deleted the msaa branch September 28, 2018 00:37
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bluemarvin bluemarvin bluemarvin requested changes

@keianhzo keianhzo keianhzo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@MortimerGoro @bluemarvin @keianhzo @larsbergstrom