Skip to content
This repository has been archived by the owner on Jul 22, 2024. It is now read-only.

Add telemetry for immersive mode duration time. #575

Merged
merged 1 commit into from
Sep 28, 2018
Merged

Add telemetry for immersive mode duration time. #575

merged 1 commit into from
Sep 28, 2018

Conversation

daoshengmu
Copy link
Contributor

We would like to add a telemetry to help us figure out the avg. time spent when users in the immersive mode.

@pocmo Please help review the telemetry part. I am going to ask for the data review shortly.

@daoshengmu
Copy link
Contributor Author

Hope we can get @pocmo 's review before we merge it.

pocmo
pocmo approved these changes Sep 28, 2018
View reviewed changes
Copy link
Contributor

@pocmo pocmo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

Note that "histogram in event extras" was a workaround we used in Focus to get some first data before the GeckoView rollout. It's not the recommended way and the telemetry team may have better solutions going forward. :)

app/src/common/shared/org/mozilla/vrbrowser/VRBrowserActivity.java Outdated Show resolved Hide resolved
@daoshengmu daoshengmu merged commit e6c2ba2 into MozillaReality:master Sep 28, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bluemarvin bluemarvin bluemarvin left review comments

@MortimerGoro MortimerGoro MortimerGoro approved these changes

@pocmo pocmo pocmo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@daoshengmu @bluemarvin @pocmo @MortimerGoro @larsbergstrom