Skip to content
This repository has been archived by the owner on Jul 22, 2024. It is now read-only.

Implement UI for browser-level alert/prompt/confirm #435

Closed
nancyhang opened this issue Aug 28, 2018 · 7 comments · Fixed by #905
Closed

Implement UI for browser-level alert/prompt/confirm #435

nancyhang opened this issue Aug 28, 2018 · 7 comments · Fixed by #905
Assignees
Labels
bug This issue is a software or functional defect compatibility Web content compatibility issues in progress P1 Fix in the current development iteration
Milestone

Comments

@nancyhang
Copy link
Contributor

Hardware: All
Steps to Reproduce:

Go to: https://developer.mozilla.org/en-US/docs/Web/HTML/Element/select
Scroll to Examples.
Click on selection drop down list.

Actual Behavior:
Nothing happens.

Expected Behavior:
A selection list is presented and the user may select an item in the list.

Recommendation:
FxR need to implement UI for the various selection types a web page may present.

@nancyhang nancyhang added the v1.1 label Aug 28, 2018
@nancyhang
Copy link
Contributor Author

Linked to #234

@cvan cvan changed the title Implement UI for dialog prompts, alert, etc. Implement UI for <select> drop-down field Aug 29, 2018
@cvan cvan changed the title Implement UI for <select> drop-down field Implement UI for alert/window/prompt Aug 29, 2018
@cvan
Copy link
Contributor

cvan commented Aug 29, 2018

Sounds good – thank you! Let's leave issue #234 for implementing the UI for <select>. I've changed the title for alert/prompt/confirm. This week I'll file follow-up issues for the various other fields that need design and engineering work (e.g., some of the <input> fields do not focus at all, which is crucial to fix).

@cvan
Copy link
Contributor

cvan commented Sep 7, 2018

Anyone feel free to disagree, but I vote for this to be a P0 for v1.0. alert/confirm/prompt and Basic-Auth Portal prompts are quite common on web pages. And not supporting them could prevent web pages from being accessed (i.e., password-protected pages), getting user input to properly function (e.g., confirm/prompt), or errors thrown as alerts get swallowed (e.g., all Unity WebGL- or WebVR-exported applications).

@keianhzo
Copy link
Contributor

keianhzo commented Sep 7, 2018

Those three should be pretty simple to implement +1 for v1.0.

@nancyhang
Copy link
Contributor Author

This will remain as v1.1 until we get the other high priority P0 completed.

@avrignaud avrignaud removed the v1.1 label Oct 30, 2018
@cvan cvan added the P0 Hotfix or blocker during release preparation label Nov 3, 2018
@cvan cvan added P1 Fix in the current development iteration backlog bug This issue is a software or functional defect compatibility Web content compatibility issues and removed P0 Hotfix or blocker during release preparation labels Nov 27, 2018
@cvan cvan changed the title Implement UI for alert/window/prompt Implement UI for browser-level alert/prompt/confirm Nov 27, 2018
@cvan
Copy link
Contributor

cvan commented Nov 27, 2018

test cases: https://webxr.sh/dialogues (https://webxr.sh/d)

@cvan cvan added this to the v1.2 milestone Dec 11, 2018
@keianhzo keianhzo self-assigned this Dec 14, 2018
@cvan
Copy link
Contributor

cvan commented Dec 14, 2018

we can use the same UI provided in #234 (comment)

bluemarvin pushed a commit that referenced this issue Dec 20, 2018
* Fixes #435 Added support for alert/prompt/confirm

* Fixed layout reference that caused a TC failure

* Improve resizing glitch
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug This issue is a software or functional defect compatibility Web content compatibility issues in progress P1 Fix in the current development iteration
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants