This repository has been archived by the owner on Jul 22, 2024. It is now read-only.
Add support for GV beta and release builds #3599
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bluemarvin
reviewed
Jul 1, 2020
versions.gradle
Outdated
Comment on lines
61
to
66
| gecko_view.nightly_armv7a = "org.mozilla.geckoview:geckoview-nightly-armeabi-v7a:$versions.gecko_view_nightly" | ||
| gecko_view.nightly_arm64 = "org.mozilla.geckoview:geckoview-nightly-arm64-v8a:$versions.gecko_view_nightly" | ||
| gecko_view.nightly_x86_64 = "org.mozilla.geckoview:geckoview-nightly-x86_64:$versions.gecko_view_nightly" | ||
| gecko_view.beta_armv7a = "org.mozilla.geckoview:geckoview-beta-armeabi-v7a:$versions.gecko_view_beta" | ||
| gecko_view.beta_arm64 = "org.mozilla.geckoview:geckoview-beta-arm64-v8a:$versions.gecko_view_beta" | ||
| gecko_view.beta_x86_64 = "org.mozilla.geckoview:geckoview-beta-x86_64:$versions.gecko_view_beta" | ||
| gecko_view.release_armv7a = "org.mozilla.geckoview:geckoview-armeabi-v7a:$versions.gecko_view_release" | ||
| gecko_view.release_arm64 = "org.mozilla.geckoview:geckoview-arm64-v8a:$versions.gecko_view_release" | ||
| gecko_view.release_x86_64 = "org.mozilla.geckoview:geckoview-x86_64:$versions.gecko_view_release" |
There was a problem hiding this comment.
I don't think we need the armv7a anymore?
There was a problem hiding this comment.
correct, I have removed the armv7 dependencies
bluemarvin
reviewed
Jul 2, 2020
| arm64Implementation deps.gecko_view.nightly_arm64 | ||
| x86_64Implementation deps.gecko_view.nightly_x86_64 | ||
| // "nightly" or "beta" or "release" | ||
| def branch = "nightly" |
There was a problem hiding this comment.
I wonder if branch should be set in versions.gradle? Probably fine since we need to think about how we are going to handle this for future releases.
bluemarvin
approved these changes
Jul 2, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3369
I could add a flavor or user property to add more dynamic options to select the branch if we consider it's worth it