This repository has been archived by the owner on Jul 22, 2024. It is now read-only.
Support Thai keyboard. #3544
Merged
Support Thai keyboard. #3544
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daoshengmu
force-pushed
the
thaiKeyboard
branch
2 times, most recently
from
bf77167 to
92f4c1c
Compare
|
@daoshengmu waiting for the URL bar padding fix. Once it's added I'll merge. |
Is this a separate issue? I don't see it in the v11 milestone. |
Same here. I have fixed it in this PR. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3487.
I notice Android and iOS have different implementation when dealing vowels. Android can't display that little circle under a vowel like 'ึ`.
Besides, Android app will stack the coming vowels even though we can't see the stacked vowels in Android app (I believe they are cut-off), they indeed exist if we backspace them. We also can produce it when using Android Chrome and type a character with multiple vowels in the search bar.
So, I am looking for a way to stop showing the vowels that are out of vertical boundary. It might be an attribute in our EditText. @keianhzo do you have idea about this?