Skip to content
This repository has been archived by the owner on Jul 22, 2024. It is now read-only.

Return an empty string when no result in zh-CN codebook #3496

Merged
merged 1 commit into from
Jun 12, 2020

Conversation

daoshengmu
Copy link
Contributor

Fixes #3490 and #3417

It is happened when trying to find a word from the code book for replacing a substring in composing text. But, sometimes we can't. (like n ,) So, in that case, we can just return an empty string for composing.

@daoshengmu daoshengmu self-assigned this Jun 11, 2020
@daoshengmu daoshengmu requested a review from keianhzo June 11, 2020 19:39
@daoshengmu daoshengmu added this to the #11 polish milestone Jun 11, 2020
Copy link
Contributor

@keianhzo keianhzo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@keianhzo keianhzo self-requested a review June 12, 2020 14:02
@keianhzo keianhzo merged commit b36aaa6 into master Jun 12, 2020
@keianhzo keianhzo deleted the fixCNKeyboardCrash branch June 12, 2020 14:02
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
2 participants