-
Notifications
You must be signed in to change notification settings - Fork 218
Multiple window and immersive mode time measurement telemetry. #3430
Conversation
b2483e8
to
ee960aa
Compare
After updating to AC 41.0.0, I will see
in my local. This error will not block me to generate installations and even Taskcluster build still be good. The workaround should be [1]
However, once I force our build config to use antlr4:4.5.3. I will see another error Moreover, if choosing to jump to AC 42.0.0. the build failure would block us. It looks like our build environment is using |
ee960aa
to
4185ac7
Compare
app/src/common/shared/org/mozilla/vrbrowser/ui/widgets/WindowWidget.java
Show resolved
Hide resolved
4185ac7
to
dd5c3d7
Compare
dd5c3d7
to
f0c593f
Compare
f0c593f
to
2153be6
Compare
@Dexterp37 Please help review the usage of Glean. It should be the last phase of migrating telemetry service data. |
app/metrics.yaml
Outdated
bugs: | ||
- https://github.com/MozillaReality/FirefoxReality/issues/2279 | ||
data_reviews: | ||
- https://github.com/MozillaReality/FirefoxReality/pull/xxx |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please don't forget to add the data review response link here and to the other metrics.
2153be6
to
20d6f7f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
r+ on the glean api usage. Please make sure to have this code reviewed by a FxR peer as well and to update the data-review url in the YAML files before merging.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Needs rebase and update the data_reviews
when ready.
20d6f7f
to
e8c1a04
Compare
Request for data collection review formAll questions are mandatory. You must receive review from a data steward peer on your responses to these questions before shipping new data collection.
Until 11/01/2020 and will consider to expand the expire date if need.
@chutten, please help data review. @Dexterp37 was concerned about if we can collect the data from using private window mode. If it is unavailable, I could remove them if need. |
e8c1a04
to
bbe5ab3
Compare
In future please include a full list of the data collections in the answer to Question 5. Data Collection in Private Browsing Mode is permitted under the guidelines shared by Ehsan in September of 2018. DATA COLLECTION REVIEW RESPONSE:
Yes. This collection is Glean so is documented in its metrics documentation.
Yes. This collection is Glean so can be controlled through Firefox Reality's Preferences.
No. This collection will expire 2020-11-01.
Category 2, Interaction.
Default on for all channels.
No.
Yes.
Yes. Daosheng Mu is responsible for renewing or removing the collection before it expires 2020-11-01. Result: datareview+ |
bbe5ab3
to
e0193db
Compare
Fixes #2279.
AC 41.0.0 already provides the ability to use coarse time telemetry, so I would migrate our resting metrics from Telemetry Service.