This repository has been archived by the owner on Jul 22, 2024. It is now read-only.
Prevent duplicated setActive(false) calls #3376
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bluemarvin
reviewed
May 14, 2020
Comment on lines
770
to
775
| if (mState.mSession != null && mState.isActive() == aActive) { | ||
| return; | ||
| } |
There was a problem hiding this comment.
I think setActive(true); is okay and since we can get out of sync, I think we should just guard against setActive(false) twice?
MortimerGoro
force-pushed
the
v10/duplicated_set_active
branch
from
db7c945 to
b70161b
Compare
bluemarvin
approved these changes
May 14, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems that calling setActiva(false) twice causes some issues. When we enter immersive mode we call setActive(false) on the non focused windows and we call surfaceDestroyed. If we show the Oculus menu later, setActive(false) is called again
Fixes #3375