Skip to content
This repository has been archived by the owner on Jul 22, 2024. It is now read-only.

The Downloads list is wrongly resorted after a quit/resume #3321

Closed
Softvision-RemusDranca opened this issue May 4, 2020 · 1 comment · Fixed by #3326
Closed

The Downloads list is wrongly resorted after a quit/resume #3321

Softvision-RemusDranca opened this issue May 4, 2020 · 1 comment · Fixed by #3326
Assignees
@keianhzo
Labels
in progress [QA]:Normal issue Label for QA to mark normal issues logged [QA]:Verified fixed Label for QA to mark verified fixed issues
Milestone
#10 features

Comments

@Softvision-RemusDranca
Copy link

Softvision-RemusDranca commented May 4, 2020 •
edited
Loading

[Affected Versions]:

  • Firefox Reality version 10 RC4 (2999129).

[Affected Platforms]:

  • Pico Neo 2 - Android - 8.1.0
  • Oculus Quest - Android 7.1.1
  • HTC Vive Focus - Android 7.1.2

[Prerequisites]:

  • The headset is turned on and the app is opened.
  • Have multiple downloaded files in the list.

[Steps to reproduce]:

  1. Click the Downloads button from the tray.
  2. Click the "Sort By" button and choose an option (ex "Smallest".)
  3. Quit and resume the app.
  4. Observe if the sorted option is kept.

[Expected results]:

  • The files are sorted in the last chosen option.

[Actual results]:

  • The files are resorted.

[Notes]:

  • On HTC and Pico devices the issue is reproducible only after the app is forced stopped.
  • As a side effect of this issue if there are a lot of downloads available, after resume the Downloads page will take a few seconds to load.
  • It seems like the files are not resorted in a specific order.
  • Attached is a screen recording of the issue: link.
@Softvision-RemusDranca Softvision-RemusDranca added the [QA]:Normal issue Label for QA to mark normal issues logged label May 4, 2020
@emstanley emstanley modified the milestones: #10 features, #11 polish May 4, 2020
@keianhzo keianhzo mentioned this issue May 4, 2020
Merged
@keianhzo keianhzo self-assigned this May 4, 2020
@keianhzo keianhzo modified the milestones: #11 polish, #10 features May 4, 2020
bluemarvin pushed a commit that referenced this issue May 5, 2020
@keianhzo
Fixes #3321 Fixes #3320 Fixes #3317 Downloads list improvements (#3326)
d0f94b5 
* Improve downloads sorting


Reset scroll position after changing sorting

* Fix sorting restoration
@Softvision-RemusDranca
Copy link
Author

I have verified this issue and it's no longer reproducible with the Firefox Reality version 10 RC5 (e84d3c9). The last sort option selected remains set after a quit/resume.

Tested on HTC Vive Focus (Android 7.1.2), Oculus Quest (Android 7.1.1), and Pico Neo 2 (Android - 8.1.0) devices.

@Softvision-RemusDranca Softvision-RemusDranca added the [QA]:Verified fixed Label for QA to mark verified fixed issues label May 11, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@keianhzo keianhzo

Labels
in progress [QA]:Normal issue Label for QA to mark normal issues logged [QA]:Verified fixed Label for QA to mark verified fixed issues
Projects
None yet
Milestone
#10 features
Development

Successfully merging a pull request may close this issue.

Fixes #3321 Fixes #3320 Fixes #3317 Downloads list improvements MozillaReality/FirefoxReality
3 participants
@emstanley @keianhzo @Softvision-RemusDranca