Skip to content
This repository has been archived by the owner on Jul 22, 2024. It is now read-only.

Closes #3277 Improved setSession code #3297

Merged
merged 2 commits into from
May 28, 2020
Merged

Conversation

keianhzo
Copy link
Contributor

Closes #3277 Refactor of the setSession code to set the previous session active state and setup the listeners.

@keianhzo keianhzo self-assigned this Apr 30, 2020
@keianhzo keianhzo added this to the #11 polish milestone Apr 30, 2020
@keianhzo keianhzo force-pushed the v11/window_session_listeners branch 2 times, most recently from 3f180f8 to 9acc787 Compare May 11, 2020 10:34
@keianhzo keianhzo requested a review from MortimerGoro May 11, 2020 10:36
@keianhzo
Copy link
Contributor Author

@bluemarvin I've rebased and I had to resolve a conflict affecting your latest patch #3350. I've tested and seems to be good but maybe you want to take a look.

Simplify setActive to only deactivate the old session


Use state for setActive
@keianhzo keianhzo force-pushed the v11/window_session_listeners branch from f14f52d to 08a5be8 Compare May 18, 2020 12:35
@keianhzo keianhzo requested a review from bluemarvin May 18, 2020 12:36
@keianhzo keianhzo requested a review from bluemarvin May 28, 2020 15:14
@bluemarvin bluemarvin merged commit 05537c3 into master May 28, 2020
@bluemarvin bluemarvin deleted the v11/window_session_listeners branch May 28, 2020 20:12
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make setupListener calls safer
3 participants