This repository has been archived by the owner on Jul 22, 2024. It is now read-only.
Fixes #2861 Fix panels being closed on pause #3198
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
keianhzo
changed the title
bluemarvin
approved these changes
Apr 20, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2861 Flushing the back handlers on Pause was closing the library panels before saving the state.
FirefoxReality/app/src/common/shared/org/mozilla/vrbrowser/VRBrowserActivity.java
Lines 440 to 442 in 277000d
Instead of that we just exit the full-screen or immersive mode in onPause.
The related issue is prior to this code so shouldn't be the cause but I couldn't really reproduce it after fixing it so I might have been fixed by other patch.