Skip to content
This repository has been archived by the owner on Jul 22, 2024. It is now read-only.

Fix halo artifact on Oculus #3119

Merged
merged 1 commit into from
Apr 7, 2020
Merged

Fix halo artifact on Oculus #3119

merged 1 commit into from
Apr 7, 2020

Conversation

bluemarvin
Copy link
Contributor

Fixes #3109

@bluemarvin bluemarvin added this to the #10 features milestone Apr 6, 2020
@bluemarvin bluemarvin requested a review from MortimerGoro April 6, 2020 23:38
@bluemarvin bluemarvin self-assigned this Apr 6, 2020
@bluemarvin
Copy link
Contributor Author

@MortimerGoro I don't remember why we were using VRAPI_FRAME_LAYER_BLEND_ONE previously, but VRAPI_FRAME_LAYER_BLEND_SRC_ALPHA seems to work and fixes the halo issue.

@MortimerGoro
Copy link
Contributor

MortimerGoro commented Apr 7, 2020 •
edited
Loading

We switched to BLEND_ONE in this PR: #814
It was to fix a border artifact on the beam.

I have tested it and it looks good. My only concerns is the behavior might be different in a old runtime? I can’t test it not that I have devices updated

@bluemarvin
Copy link
Contributor Author

I think most people will have newer runtimes. I think it is safe to land.

@bluemarvin bluemarvin merged commit 2454ab2 into master Apr 7, 2020
@bluemarvin bluemarvin deleted the oculus-halo branch April 7, 2020 23:48
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@MortimerGoro MortimerGoro MortimerGoro approved these changes

Assignees

@bluemarvin bluemarvin

Labels
None yet
Projects
None yet
Milestone
#10 features
Development

Successfully merging this pull request may close these issues.

[Oculus] A Transparent background is wrongly displayed for the menus, prompts and buttons
2 participants
@bluemarvin @MortimerGoro