Skip to content
This repository has been archived by the owner on Jul 22, 2024. It is now read-only.

Set up WebXR Room Scale sizes #3065

Merged
merged 1 commit into from
Mar 27, 2020
Merged

Set up WebXR Room Scale sizes #3065

merged 1 commit into from
Mar 27, 2020

Conversation

MortimerGoro
Copy link
Contributor

No description provided.

@MortimerGoro MortimerGoro requested a review from bluemarvin March 27, 2020 15:50
@MortimerGoro MortimerGoro force-pushed the v10/stage_parameters branch from 83d450b to 7ef370c Compare March 27, 2020 15:52
@MortimerGoro MortimerGoro self-assigned this Mar 27, 2020
bluemarvin
bluemarvin suggested changes Mar 27, 2020
View reviewed changes
Copy link
Contributor

@bluemarvin bluemarvin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we need to set Cap_StageParameters if we are passing in stage size?

@bluemarvin
Copy link
Contributor

I think we need to set Cap_StageParameters if we are passing in stage size?

I see we are already setting it.

bluemarvin
bluemarvin approved these changes Mar 27, 2020
View reviewed changes
Copy link
Contributor

@bluemarvin bluemarvin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume Pico doesn't support this in the API yet?

@bluemarvin bluemarvin merged commit 28b0362 into master Mar 27, 2020
@bluemarvin bluemarvin deleted the v10/stage_parameters branch March 27, 2020 18:17
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bluemarvin bluemarvin bluemarvin approved these changes

Assignees

@MortimerGoro MortimerGoro

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MortimerGoro @bluemarvin