This repository has been archived by the owner on Jul 22, 2024. It is now read-only.
Refine Pinyin symbol keyboard and add Emoji support #3056
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daoshengmu
force-pushed
the
pinyinSymbolKeyboard
branch
from
d591891 to
a233cf5
Compare
bluemarvin
approved these changes
Mar 28, 2020
|
@keianhzo I'm going to land this. If you have any issues please file a follow up. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2974,
I notice we will have crashes when typing backslash
\in Pinyni keyboard only. It might be caused by updating to Android 29 due to Java 1.4String.replaceFirst(). [1]In conclusion, we need to replace
\\with\\\\.[1] https://bugs.java.com/bugdatabase/view_bug.do?bug_id=6421039