Skip to content
This repository has been archived by the owner on Jul 22, 2024. It is now read-only.

Toggle quick permission dialog when clicking the URL bar icons #3036

Merged
merged 2 commits into from
Mar 25, 2020
Merged

Toggle quick permission dialog when clicking the URL bar icons #3036

merged 2 commits into from
Mar 25, 2020

Conversation

MortimerGoro
Copy link
Contributor

Fixes #3034

@MortimerGoro MortimerGoro added this to the #10 features milestone Mar 24, 2020
@MortimerGoro MortimerGoro self-assigned this Mar 24, 2020
@keianhzo keianhzo self-requested a review March 24, 2020 14:07
keianhzo
keianhzo suggested changes Mar 24, 2020
View reviewed changes
Copy link
Contributor

@keianhzo keianhzo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The dialog remains opened when having multiple windows and switching to another window.

@MortimerGoro MortimerGoro force-pushed the v10/toggle_quick_permission branch from 6c4553a to df894fc Compare March 24, 2020 16:11
@MortimerGoro
Copy link
Contributor Author

@keianhzo ready

@MortimerGoro MortimerGoro force-pushed the v10/toggle_quick_permission branch from df894fc to 3a033a0 Compare March 25, 2020 10:07
@keianhzo keianhzo self-requested a review March 25, 2020 11:18
@keianhzo keianhzo merged commit f5e424d into master Mar 25, 2020
@keianhzo keianhzo deleted the v10/toggle_quick_permission branch March 25, 2020 11:35
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@keianhzo keianhzo keianhzo approved these changes

@bluemarvin bluemarvin bluemarvin approved these changes

Assignees

@MortimerGoro MortimerGoro

Labels
None yet
Projects
None yet
Milestone
#10 features
Development

Successfully merging this pull request may close these issues.

Clicking the VR icon in the URL bar does not close the popup message.
3 participants
@MortimerGoro @bluemarvin @keianhzo