This repository has been archived by the owner on Jul 22, 2024. It is now read-only.
Do not show WebXR icon in the content feed #3028
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bluemarvin
reviewed
Mar 24, 2020
app/src/common/shared/org/mozilla/vrbrowser/ui/viewmodel/WindowViewModel.java
Outdated
Show resolved
Hide resolved
keianhzo
suggested changes
Mar 24, 2020
| @Override | ||
| public void onChanged(Spannable o) { | ||
| String current = url.getValue().toString(); | ||
| String feed = getApplication().getString(R.string.homepage_url); |
There was a problem hiding this comment.
Can we move this to UrlUtils? We already have some helper methods there for identifying specific URLs.
MortimerGoro
force-pushed
the
v10/webxr_content_feed
branch
from
696c878 to
6039c64
Compare
bluemarvin
approved these changes
Mar 24, 2020
keianhzo
approved these changes
Mar 24, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.