Skip to content
This repository has been archived by the owner on Jul 22, 2024. It is now read-only.

Update grade & build tools #2930

Merged
merged 3 commits into from
Mar 18, 2020
Merged

Update grade & build tools #2930

merged 3 commits into from
Mar 18, 2020

Conversation

MortimerGoro
Copy link
Contributor

No description provided.

@MortimerGoro MortimerGoro self-assigned this Mar 9, 2020
@bluemarvin
Copy link
Contributor

This needs to wait until I get the docker image updated. Currently blocked on a slow curl upload to autograph.

Copy link
Contributor

@bluemarvin bluemarvin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unit test fails:
./gradlew testNoapiArm64DebugUnitTest
Not sure why it is so fragile.

@daoshengmu
Copy link
Contributor

The failure is because robolectric needs to use SDK 28, otherwise, you can choose to upgrade it to 4.3.1. However, it needs Java 9.

@keianhzo
Copy link
Contributor

@daoshengmu It seems that we can force Robolectric to use SDK 28. I've pushed a fix.

@daoshengmu
Copy link
Contributor

@daoshengmu It seems that we can force Robolectric to use SDK 28. I've pushed a fix.

It works properly for me. GJ!

Copy link
Contributor

@bluemarvin bluemarvin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like it is ready to land.

@bluemarvin bluemarvin merged commit 25cca5a into master Mar 18, 2020
@bluemarvin bluemarvin deleted the gradle branch March 18, 2020 16:49
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants