This repository has been archived by the owner on Jul 22, 2024. It is now read-only.
Add support for GWE enabled MozillaSpeechLibrary #2896
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The API key is requested, we'll update when we get it. I'll file a task for this. |
bluemarvin
approved these changes
Mar 3, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1580 MozillaSpeechLibrary has now support for GeckoWebExecutor where available so we can safely remove all the http client dependencies that we were using from com.loopj.android and cz.mesebera.android.
This PR migrates all usage of those libraries to GWE and bumps the MozillaSpeechLibrary version to 1.0.11 which already implements support for GWE. mozilla/androidspeech#27
At some point the MLS stopped supporting requests without an API key, I saw it while debugging the GWE migration of the client. I've request an API to the MLS team. This will remain a draft until we get an API key for FxR.