Skip to content
This repository has been archived by the owner on Jul 22, 2024. It is now read-only.

Theater mode is displayed in flat or curved mode depending on how many windows are opened #2660

Closed
Softvision-GeluHaiduc opened this issue Jan 16, 2020 · 3 comments · Fixed by #2690 or #3305
Closed

Theater mode is displayed in flat or curved mode depending on how many windows are opened #2660

Softvision-GeluHaiduc opened this issue Jan 16, 2020 · 3 comments · Fixed by #2690 or #3305
Assignees
@keianhzo
Labels
in progress [QA]:Normal issue Label for QA to mark normal issues logged [QA]:Verified fixed Label for QA to mark verified fixed issues
Milestone
#11 polish

Comments

@Softvision-GeluHaiduc
Copy link

[Affected Versions]:

  • Firefox Reality version 8 RC1 (7a444d0)

[Affected Platforms]:

  • Oculus Quest - Android 7.1.1
  • HTC Vive Focus Plus - Android 7.1.2

[Prerequisites]:

  • The Firefox Reality browser is opened.

[Steps to reproduce]:

  1. Navigate to a normal video on YouTube and enter theater/full screen mode.
  2. Observe the displayed window.
  3. Exit theater (full screen) mode and click the “+” button in the menu tray.
  4. Enter theater/full screen mode again.
  5. Observe the displayed window.

[Expected results]:

  • The window is displayed flat while in theater/fullscreen mode.
    OR
  • The window is displayed curved while in theater/fullscreen mode.

[Actual results]:

  • Depending on if there is one window or multiple windows opened the theater/fullscreen mode display is flat or curved.

[Notes]:

  • Attached a screen recording of the issue here.
@Softvision-GeluHaiduc Softvision-GeluHaiduc added the [QA]:Normal issue Label for QA to mark normal issues logged label Jan 16, 2020
@bluemarvin
Copy link
Contributor

This has been an issue since we added multi-window support.

@MortimerGoro MortimerGoro self-assigned this Jan 17, 2020
@MortimerGoro MortimerGoro mentioned this issue Jan 21, 2020
Merged
@Softvision-GeluHaiduc
Copy link
Author

I have verified this issue with the latest Firefox Reality version 9-40290101 (854287c) installed on the Oculus Go, Quest, HTC Vive Focus and Focus Plus headsets.
Now, the view is displayed flat regardless of how many windows there are opened, except for when the curved display setting is on.
However the theater mode menu tray is still displayed in flat or curved mode depending on the number of windows, the issue is more visible when the projection or brightness menu are opened, the behaviour can be seen in this video.

@bluemarvin bluemarvin added this to the #10 features milestone Feb 12, 2020
@emstanley emstanley modified the milestones: #10 features, #11 polish Mar 23, 2020
@keianhzo keianhzo mentioned this issue May 1, 2020
Merged
@keianhzo keianhzo assigned keianhzo and unassigned MortimerGoro May 1, 2020
bluemarvin pushed a commit that referenced this issue May 1, 2020
@keianhzo
Fixes #2660 Set the correct fullscreen controls and menus curved state (
78da896 
#3305)

* Fix navigation bar and menus curved mode

* Close brightness/projection menus when clicked in the widget
@Softvision-GeluHaiduc
Copy link
Author

I have verified that this issue is no longer reproducible with the latest Firefox Reality version 10 RC5 (e84d3c9) installed on the Oculus Go, HTC Vive Focus Plus, Pico Neo2 and Pico G2 4K headsets.
Now, the theater mode is displayed correctly.

@Softvision-GeluHaiduc Softvision-GeluHaiduc added the [QA]:Verified fixed Label for QA to mark verified fixed issues label May 11, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@keianhzo keianhzo

Labels
in progress [QA]:Normal issue Label for QA to mark normal issues logged [QA]:Verified fixed Label for QA to mark verified fixed issues
Projects
None yet
Milestone
#11 polish
5 participants
@bluemarvin @emstanley @keianhzo @MortimerGoro @Softvision-GeluHaiduc