Skip to content
This repository has been archived by the owner on Jul 22, 2024. It is now read-only.

The "Miniplayer" list from the Youtube website is not scrollable #2552

Closed
Softvision-RemusDranca opened this issue Dec 27, 2019 · 7 comments · Fixed by #3453
Closed

The "Miniplayer" list from the Youtube website is not scrollable #2552

Softvision-RemusDranca opened this issue Dec 27, 2019 · 7 comments · Fixed by #3453
Assignees
@daron-walters
Labels
blocked in progress [QA]:Major issue Label for QA to mark major issues logged [QA]:Verified fixed Label for QA to mark verified fixed issues Youtube Youtube related issue
Milestone
#11 polish

Comments

@Softvision-RemusDranca
Copy link

[Notes]:

  • This issue is also reproducible on windows having the 1x size or smaller if the "Miniplayer" is expanded on full screen.

[Affected Versions]:

  • Firefox Reality version 8-33580833 (777a0ae).

[Affected Platforms]:

  • Oculus Quest - Android 7.1.1
  • Oculus Go - Android 7.1.2
  • HTC Vive Focus Plus - Android 7.1.2
  • HTC Vive Focus - Android 7.1.2

[Prerequisites]:

  • The headset is turned on and the browser is opened.

[Steps to reproduce]:

  1. Navigate to the Youtube website.
  2. Add at least 5 videos to "Queue" list.
  3. Click the "Down" arrow are from the "Miniplayer" list.
  4. Observe the list.

[Expected results]:

  • A vertical scrollbar is displayed on the right side of the list.

[Actual results]:

  • No scrollbar is displayed and the list is not scrollable.

[Additional Notes]:
@Softvision-RemusDranca Softvision-RemusDranca added the [QA]:Major issue Label for QA to mark major issues logged label Dec 27, 2019
@jvonitter
Copy link
Contributor

@MortimerGoro thoughts on this one? possibly related to #2550 ?

@jvonitter jvonitter added this to the #8 features milestone Jan 8, 2020
@MortimerGoro MortimerGoro self-assigned this Jan 9, 2020
@MortimerGoro
Copy link
Contributor

I don't think they are related. As it also happens in Firefox desktop desktop I'd wait for the webcompat issue being fixed: webcompat/web-bugs#46266

@jvonitter jvonitter modified the milestones: #8 features, Backlog Jan 9, 2020
@daron-walters
Copy link
Contributor

I have been researching this ticket for a few days and I think there are multiple problems

  1. isues with flexbox and firefox in general (placing the overflow-y) on the correct flexbox element may show a scrollbar that doesnt function

  2. I think the bigger problem is that the whole miniplayer element is the height of the page (a page that dynamically grows) so researching making the miniplayer height fixed/absolute.

daron-walters added a commit that referenced this issue Apr 30, 2020
@daron-walters
Fixes #2552 Added css styles to youtube miniplayer list to give a fix…
c302316 
…ed height. Also added scroll style to force scrollbar
@daron-walters
Copy link
Contributor

daron-walters commented Apr 30, 2020 •
edited
Loading

Here is a link to my fix on local. I have some a follow up question

1 The size of the scrollbar. It seems pretty thin Do we need to see if this can be fixed via css?

daron-walters added a commit that referenced this issue Apr 30, 2020
@daron-walters
Fixes #2552 Added css styles to youtube miniplayer list to give a fix…
553861c 
…ed height. Also added scroll style to force scrollbar

Fixes #2552 Added css styles to youtube miniplayer list to give a fixed height.  Also added scroll style to force scrollbar

Fixes #2552 Added css styles to youtube miniplayer list to give a fixed height.  Also added scroll style to force scrollbar
daron-walters added a commit that referenced this issue Apr 30, 2020
@daron-walters
Fixes #2552 - Added css to force fixed width and added overflow to al…
04d4b58 
…low scrollbar on the queued items flex container on the miniplayer
@bluemarvin
Copy link
Contributor

Here is a link to my fix on local. I have some a follow up question

1 The size of the scrollbar. It seems pretty thin Do we need to see if this can be fixed via css?

The scroll bars in GeckoView are visual and not interactive currently (see #317). This is an artifact of GeckoView being intended for mobile phones.

@bluemarvin bluemarvin added the Youtube Youtube related issue label Apr 30, 2020
@daron-walters
Copy link
Contributor

thanks for the comment @bluemarvin read through tie issue you included. It actually answered some other ui questions I had.

daron-walters added a commit that referenced this issue May 28, 2020
@daron-walters
Fixes #2552 -Added a fixed height (not percentage) of miniplayer item…
5e58fda 
…s so that queue can be scrolled
@daron-walters daron-walters linked a pull request Jun 2, 2020 that will close this issue
Fixes #2552 -Added a fixed height (not percentage) of miniplayer item… #3453
Merged
@bluemarvin bluemarvin modified the milestones: Backlog, #11 polish Jun 2, 2020
keianhzo pushed a commit that referenced this issue Jun 3, 2020
@daron-walters
Fixes #2552 -Added a fixed height (not percentage) of miniplayer item…
2a2f8dd 
…s so that queue can be scrolled (#3453)
@Softvision-RemusDranca
Copy link
Author

I have verified this issue and it's no longer reproducible using Firefox Reality 11-141551002 (8f4de9a). Now, the "Miniplayer" list from the Youtube website is scrollable.

Tested on HTC Vive Focus (Android 7.1.2), Oculus Quest (Android 7.1.1), and Pico Neo 2 (Android - 8.1.0) devices.

@Softvision-RemusDranca Softvision-RemusDranca added the [QA]:Verified fixed Label for QA to mark verified fixed issues label Jun 4, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@daron-walters daron-walters

Labels
blocked in progress [QA]:Major issue Label for QA to mark major issues logged [QA]:Verified fixed Label for QA to mark verified fixed issues Youtube Youtube related issue
Projects
None yet
Milestone
#11 polish
5 participants
@bluemarvin @MortimerGoro @daron-walters @Softvision-RemusDranca @jvonitter