Skip to content
This repository has been archived by the owner on Jul 22, 2024. It is now read-only.

Add dontobfuscate option to pro-guard rules. Fixes #1683 #1688

Merged
merged 1 commit into from
Aug 28, 2019

Conversation

bluemarvin
Copy link
Contributor

No description provided.

@bluemarvin bluemarvin added the enhancement This issue is a new feature or request label Aug 27, 2019
@bluemarvin bluemarvin added this to the v1.4 milestone Aug 27, 2019
@bluemarvin bluemarvin requested a review from keianhzo August 27, 2019 22:49
@bluemarvin bluemarvin self-assigned this Aug 27, 2019
@bluemarvin
Copy link
Contributor Author

I didn't see any change in APK size when I set this flag. Unfortunately it looks like the line numbers are still useless. Not sure if it is worth landing.

@bluemarvin
Copy link
Contributor Author

It looks like there is no way to keep line number when using r8. We would need to get crash stats to support a mapping file that is uploaded with each release and staging build.

@keianhzo
Copy link
Contributor

keianhzo commented Aug 28, 2019

It seems minification itself mangles the line number and that cannot be changed so I guess we will need to upload the mappings to crash-stats to get useful stacktraces. Not sure though if the stores themselves support uploading mapping files. I know that Google Play does so you can get the original stack traces in the dashboard but I'm not sure if Oculus/HTC have that feature.

At least this commit let us know where the crash happened so it might be worth to land it while we wait for mappings support in crash-stats.

@keianhzo keianhzo merged commit 8aff84c into master Aug 28, 2019
@bluemarvin bluemarvin deleted the dontobfuscate branch August 28, 2019 15:03
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement This issue is a new feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants