Skip to content
This repository has been archived by the owner on Jul 22, 2024. It is now read-only.

Do not make multi-windows visible if there is only one window #1675

Merged
merged 2 commits into from
Aug 27, 2019

Conversation

keianhzo
Copy link
Contributor

Fixes #1633 Do not make multi-windows visible if there is only one window

Copy link
Contributor

@MortimerGoro MortimerGoro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Related: Should we still show the close button for a single private window? We always had that feature before adding multiwindow. Close button erases al private sessions vs private button in the tray switches to regular but keeps private sessions alive.

@bluemarvin
Copy link
Contributor

We definitely need a way to clear private browsing. That’s what the close button was originally for.

@keianhzo
Copy link
Contributor Author

I've updated the PR to also show the close button when resize is finished in private mode.

@bluemarvin bluemarvin merged commit 9be94c1 into master Aug 27, 2019
@bluemarvin bluemarvin deleted the mw_controls_fixes branch August 27, 2019 20:04
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The multiwindow controls appear after a resize of a window
3 participants