This repository has been archived by the owner on Jul 22, 2024. It is now read-only.
New Prompt API #1560
Merged
New Prompt API #1560
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bluemarvin
approved these changes
Aug 12, 2019
| } | ||
| } | ||
| public GeckoResult<PromptResponse> onAlertPrompt(@NonNull GeckoSession geckoSession, @NonNull AlertPrompt alertPrompt) { | ||
| if (mPromptDelegate != null) |
There was a problem hiding this comment.
nit: I prefer to always use {} with if statements. I've fixed too may bugs in the past where they were left off and then some one added a second line with out realizing the curly brackets were missing. I just grepped the code and see we have a lot of if statements with out {} so I will file a follow up to update the code.
|
I'm going to land this as it also fixes remote debugging. We can address any issues in a follow up. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1557 Gecko bump and new prompt API update