Skip to content
This repository has been archived by the owner on Jul 22, 2024. It is now read-only.

Dialog for requesting permission for storing voice samples #1507

Merged
merged 3 commits into from
Aug 6, 2019

Conversation

keianhzo
Copy link
Contributor

@keianhzo keianhzo commented Aug 5, 2019

Fixes #641 A dialog has been added to ask the user for permission to store voice samples and transcriptions.

Copy link
Contributor

@bluemarvin bluemarvin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The first time clicking on the voice search microphone shows the dialog to collect voice samples. If you decline, it doesn't continue on to do the voice search.

@keianhzo keianhzo requested a review from bluemarvin August 6, 2019 07:08
@keianhzo
Copy link
Contributor Author

keianhzo commented Aug 6, 2019

@bluemarvin Fixed

@bluemarvin
Copy link
Contributor

I'm going to land this. If @MortimerGoro has any feedback it can be done in a follow up.

@bluemarvin bluemarvin merged commit 483f245 into master Aug 6, 2019
@bluemarvin bluemarvin deleted the voice_data branch August 7, 2019 21:17
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Speech/Voice Input Permissions
2 participants