This repository has been archived by the owner on Jul 22, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 218
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MortimerGoro
force-pushed
the
experimental/multiwindow
branch
from
July 26, 2019 17:23
7ed2d3f
to
9e3f9c2
Compare
MortimerGoro
force-pushed
the
experimental/multiwindow
branch
2 times, most recently
from
August 2, 2019 10:00
856e1f1
to
bec24ba
Compare
bluemarvin
approved these changes
Aug 2, 2019
Refactor of the current sessions code and added support for multi window.
Always update all session when a session settings changes
…ight window resizes.
Also added support for bookmarks in all the windows as stated in the spec: #1331
Now when a window it's closed it's underlying sessions are closed.
Also fixed a regression that made session not to close when a window is closed
…dow the front one
The home page was being loaded after a session restore. Now the home page is only loaded if the session is not restored. Also fixed some session restore issues to also restore session settings.
…ch time windows are updated
keianhzo
force-pushed
the
experimental/multiwindow
branch
from
August 2, 2019 19:08
6e0abae
to
44bb21f
Compare
This was referenced Aug 5, 2019
Closed
Closed
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We should get this to start testing in master. it will make it easier to rebase new features.
In the case we don't want to include it it in the next release we can just hide the add window buttons. With a single window it should be as stable as current master.