-
Notifications
You must be signed in to change notification settings - Fork 218
Conversation
39274fb
to
b2e74bd
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Moving the keyboard with curved windows feels off to me. Especially when moving to the extreme left as the keyboard starts to jitter.
Additionally, It doesn't seem there is a way to reset the keyboard to the default position?
app/src/common/shared/org/mozilla/vrbrowser/browser/SettingsStore.java
Outdated
Show resolved
Hide resolved
This is by design. Once users move it, they can move it wherever they want including the default position. It should reset once they leave the app. |
The keyboard position is saved between runs and there is no indication when the user has it back in the default position. Additionally, I notice that you can move the keyboard farther to the right than to the left. This seems like an odd constraint. |
There's nothing really special about the specific default position. If a user wants it below the awesomebar, they can move it there. If they want it somewhere else, that's ok too. I think whether or not it should reset between runs is something we should consider after we use for a while. If it persists between sessions now, let's see how that feels and switch it if it's bad.
That does seem weird and not intentional. |
b2e74bd
to
0f8fb84
Compare
PR updated with:
|
I'll improve curved mode movement in a follow-up because I need the math improvements from the |
Fixes #1146