This repository has been archived by the owner on Jul 22, 2024. It is now read-only.
Fix inactive forward button for videos on youtube.com #1463
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MortimerGoro
force-pushed
the
youtube_forward
branch
from
476f5e4 to
e8a0232
Compare
bluemarvin
approved these changes
Jul 26, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1426
Found the problem after some research. It seems that youtube processes the
disable_polymerparameter but removes it from the URL at some point. This causes another override when going back to a previous youtube video, and the forward action is lost there.GV doesn't have an API to override URLs. You need to cancel the current load and perform another
loadUri. So I decided to add a history override from the webextension when the page is unloaded to get the parameter back.