This repository has been archived by the owner on Jul 22, 2024. It is now read-only.
Introduce a centralized places.kt which owns storage #1406
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This lets us access storage backends from different parts of the system at the same time. E.g. from both BookmarksStore as well as the upcoming Services sync integration.
bluemarvin
added
the
task
keianhzo
approved these changes
Jul 17, 2019
MortimerGoro
approved these changes
Jul 17, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Starting to split-off parts of the FxA/sync work into PRs that can land on master now, and PRs that will land on a feature branch.
This lets us access storage backends from different parts of the system
at the same time. E.g. from both BookmarksStore as well as the upcoming Services
sync integration.