Fix context menu still displayed after clicking the clear button (#2193)

MozillaReality · Nov 7, 2019 · 8e45d1f · 8e45d1f
1 parent aa1a7d9
commit 8e45d1f
Showing 1 changed file with 15 additions and 6 deletions.
diff --git a/app/src/common/shared/org/mozilla/vrbrowser/ui/widgets/WindowWidget.java b/app/src/common/shared/org/mozilla/vrbrowser/ui/widgets/WindowWidget.java
@@ -309,7 +309,7 @@ public void onResume() {
 
     public void close() {
         TelemetryWrapper.closeWindowEvent(mWindowId);
-
+        hideContextMenus();
         releaseWidget();
         mBookmarksView.onDestroy();
         mHistoryView.onDestroy();
@@ -1429,14 +1429,22 @@ public void onFxASynSettings(@NonNull View view) {
 
     private void hideContextMenus() {
         if (mContextMenu != null) {
-            mContextMenu.hide(REMOVE_WIDGET);
-            mContextMenu.releaseWidget();
+            if (!mContextMenu.isReleased()) {
+                if (mContextMenu.isVisible()) {
+                    mContextMenu.hide(REMOVE_WIDGET);
+                }
+                mContextMenu.releaseWidget();
+            }
             mContextMenu = null;
         }
         if (mSelectionMenu != null) {
             mSelectionMenu.setDelegate((SelectionActionWidget.Delegate)null);
-            mSelectionMenu.hide(REMOVE_WIDGET);
-            mSelectionMenu.releaseWidget();
+            if (!mSelectionMenu.isReleased()) {
+                if (mSelectionMenu.isVisible()) {
+                    mSelectionMenu.hide(REMOVE_WIDGET);
+                }
+                mSelectionMenu.releaseWidget();
+            }
             mSelectionMenu = null;
         }
 
@@ -1445,7 +1453,8 @@ private void hideContextMenus() {
             mWidgetManager.updateWidget(this);
         }
 
-        if (mLibraryItemContextMenu != null && mLibraryItemContextMenu.isVisible()) {
+        if (mLibraryItemContextMenu != null && !mLibraryItemContextMenu.isReleased()
+            && mLibraryItemContextMenu.isVisible()) {
             mLibraryItemContextMenu.hide(REMOVE_WIDGET);
         }
     }