Skip to content
This repository has been archived by the owner on Jul 22, 2024. It is now read-only.

Commit

Permalink
Rename ping to avoid underscores
Browse files Browse the repository at this point in the history
  • Loading branch information
badboy authored and daoshengmu committed Mar 26, 2020
1 parent 5ee10ba commit 3db73db
Show file tree
Hide file tree
Showing 3 changed files with 10 additions and 10 deletions.
14 changes: 7 additions & 7 deletions app/metrics.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ distribution:
- baseline
- events
- metrics
- session_end
- session-end
bugs:
- https://github.com/MozillaReality/FirefoxReality/issues/1420
data_reviews:
Expand All @@ -30,7 +30,7 @@ url:
domains:
type: counter
send_in_pings:
- session_end
- session-end
description: >
Counting how many domains are visited in a session.
bugs:
Expand All @@ -44,7 +44,7 @@ url:
visits:
type: counter
send_in_pings:
- session_end
- session-end
description: >
Counting how many URL links are visited in a session.
bugs:
Expand Down Expand Up @@ -92,7 +92,7 @@ tabs:
description: >
Number of tabs opened during a session
send_in_pings:
- session_end
- session-end
labels:
- context_menu
- tabs_dialog
Expand All @@ -115,7 +115,7 @@ tabs:
description: >
Number of tabs activated during a session
send_in_pings:
- session_end
- session-end
bugs:
- https://github.com/MozillaReality/FirefoxReality/issues/1609
data_reviews:
Expand Down Expand Up @@ -229,12 +229,12 @@ control:
description: >
Counting how many general windows are opened in a session.
send_in_pings:
- session_end
- session-end
bugs:
- https://github.com/MozillaReality/FirefoxReality/issues/2347
data_reviews:
- https://github.com/MozillaReality/FirefoxReality/pull/2348#issuecomment-564736919
notification_emails:
- [email protected]
- [email protected]
expires: "2020-05-01"
expires: "2020-05-01"
2 changes: 1 addition & 1 deletion app/pings.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@

$schema: moz://mozilla.org/schemas/glean/pings/1-0-0

session_end:
session-end:
description: >
This ping is sent at the end of a session (when Firefox Reality switches to the background).
We usually send search and UI control metrics at the end of a session.
Expand Down
4 changes: 2 additions & 2 deletions docs/metrics.md
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ This means you might have to go searching through the dependency tree to get a f
- [baseline](#baseline)
- [events](#events)
- [metrics](#metrics)
- [session_end](#session_end)
- [session-end](#session-end)


## baseline
Expand Down Expand Up @@ -49,7 +49,7 @@ The following metrics are added to the ping:
| searches.counts |[labeled_counter](https://mozilla.github.io/glean/book/user/metrics/labeled_counters.html) |Counting how many searches are queried in a specific search engine. The search engine `identifier`s are used as keys for this metric. |[1](https://github.com/MozillaReality/FirefoxReality/pull/2241#issuecomment-557740258)||2020-05-01 |
| url.query_type |[labeled_counter](https://mozilla.github.io/glean/book/user/metrics/labeled_counters.html) |Counting how many URLs are visited in a day, by input method. |[1](https://github.com/MozillaReality/FirefoxReality/pull/2241#issuecomment-557740258)|<ul><li>type_link</li><li>type_query</li><li>voice_query</li></ul>|2020-05-01 |

## session_end
## session-end
This ping is sent at the end of a session (when Firefox Reality switches to the background). We usually send search and UI control metrics at the end of a session.

The following metrics are added to the ping:
Expand Down

0 comments on commit 3db73db

Please sign in to comment.