Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should an empty file be considered invalid? #212

Open
badboy opened this issue Dec 16, 2020 · 0 comments
Open

Should an empty file be considered invalid? #212

badboy opened this issue Dec 16, 2020 · 0 comments

Comments

@badboy
Copy link
Member

badboy commented Dec 16, 2020

For some reason yet unknown to me we saw empty data.safe.bin files for Rkv databases as used inside Firefox by Glean.
This causes issues (and crashes) because Rkv bailed out and considers an empty file to be invalid (because it can't decode the data).

Our solution is to remove the empty file and try again.

Now the question is if that's something that Rkv should handle directly? An empty file is not really invalid IMO.

(I know Rkv shouldn't create an empty file)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant