You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Jun 29, 2018. It is now read-only.
Currently we have function destroyPlayer() { ... } methods in every wrapper like soundcloud/youtube, but they are hidden in private scope and can't be called manually. Thus, if I want to f.e. destroy my soundcloud wrapper and to create youtube wrapper, I will receive Uncaught TypeError: Cannot read property 'postMessage' of null errors, because callbacks haven't been removed (similar to #427).
Simple adding of self.destroy = destroyPlayer; line to popcorn.HTMLYouTubeVideoElement.js and popcorn.HTMLSoundCloudAudioElement.js solves the problem.
I can make a pull request for that, but I'd want to be sure, that it's the best way to do it?
The text was updated successfully, but these errors were encountered:
Currently we have
function destroyPlayer() { ... }
methods in every wrapper like soundcloud/youtube, but they are hidden in private scope and can't be called manually. Thus, if I want to f.e. destroy my soundcloud wrapper and to create youtube wrapper, I will receiveUncaught TypeError: Cannot read property 'postMessage' of null
errors, because callbacks haven't been removed (similar to #427).Simple adding of
self.destroy = destroyPlayer;
line topopcorn.HTMLYouTubeVideoElement.js
andpopcorn.HTMLSoundCloudAudioElement.js
solves the problem.I can make a pull request for that, but I'd want to be sure, that it's the best way to do it?
The text was updated successfully, but these errors were encountered: